Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2870263002: Rename ScopedComPtr::Receive to ScopedComPtr::GetAddressOf (Closed)

Created:
3 years, 7 months ago by robliao
Modified:
3 years, 7 months ago
CC:
chromium-reviews, vmpstr+watch_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, dcheng, pennymac+watch_chromium.org, dougt+watch_chromium.org, dmazzoni+watch_chromium.org, mfoltz+watch_chromium.org, miu+watch_chromium.org, cbentzel+watch_chromium.org, toyoshim+midi_chromium.org, aboxhall+watch_chromium.org, grt+watch_chromium.org, chromoting-reviews_chromium.org, jam, net-reviews_chromium.org, je_julie, darin-cc_chromium.org, wanming.lin, xjz+watch_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, timvolodine, asvitkine+watch_chromium.org, mlamouri+watch-sensors_chromium.org, piman+watch_chromium.org, shalamov, riju_, Lei Zhang, wfh+watch_chromium.org, nektar+watch_chromium.org, tommycli, dtseng+watch_chromium.org, tfarina, danakj+watch_chromium.org, Mikhail
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename ScopedComPtr::Receive to ScopedComPtr::GetAddressOf This renames Receive() to GetAddressOf() to harmonize with ComPtr::GetAddressOf(). Most replacements were performed automatically with clang-tidy. BUG=638327 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2870263002 Cr-Commit-Position: refs/heads/master@{#470987} Committed: https://chromium.googlesource.com/chromium/src/+/310fa98b9861be3c4b87fd8fd9d925dc83268bc3

Patch Set 1 #

Patch Set 2 : Rebase to 2a6f440 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+480 lines, -467 lines) Patch
M base/win/scoped_comptr.h View 3 chunks +4 lines, -4 lines 0 comments Download
M base/win/scoped_comptr_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/google/google_update_win.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/importer/ie_importer_browsertest_win.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/media_galleries/win/mtp_device_delegate_impl_win.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/media_galleries/win/mtp_device_operations_util.cc View 5 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/metrics/antivirus_metrics_provider_win.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/platform_util_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/incognito_mode_prefs.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/speech/tts_win.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/accessibility/navigation_accessibility_uitest_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/win/jumplist_updater.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/win/settings_app_monitor.cc View 4 chunks +8 lines, -6 lines 0 comments Download
M chrome/installer/util/advanced_firewall_manager_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/legacy_firewall_manager_win.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/installer/util/wmi.cc View 5 chunks +15 lines, -14 lines 0 comments Download
M chrome/service/cloud_print/print_system_win.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/utility/importer/ie_importer_win.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/utility/shell_handler_impl_win.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M components/storage_monitor/portable_device_watcher_win.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M components/update_client/background_downloader_win.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M content/browser/accessibility/accessibility_event_recorder_win.cc View 1 7 chunks +9 lines, -10 lines 0 comments Download
M content/browser/accessibility/accessibility_tree_formatter_win.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/accessibility/accessibility_win_browsertest.cc View 1 20 chunks +33 lines, -37 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win_unittest.cc View 1 18 chunks +50 lines, -47 lines 0 comments Download
M content/browser/renderer_host/legacy_render_widget_host_win.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M device/generic_sensor/platform_sensor_reader_win.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M device/sensors/data_fetcher_shared_memory_win.cc View 5 chunks +11 lines, -8 lines 0 comments Download
M gpu/ipc/service/direct_composition_surface_win.cc View 1 20 chunks +46 lines, -46 lines 0 comments Download
M gpu/ipc/service/direct_composition_surface_win_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/audio/win/audio_low_latency_input_win.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M media/audio/win/core_audio_util_win.cc View 11 chunks +15 lines, -15 lines 0 comments Download
M media/audio/win/core_audio_util_win_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M media/audio/win/device_enumeration_win.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M media/base/win/mf_helpers.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M media/capture/video/win/video_capture_device_factory_win.cc View 10 chunks +14 lines, -12 lines 0 comments Download
M media/capture/video/win/video_capture_device_mf_win.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M media/capture/video/win/video_capture_device_win.cc View 12 chunks +15 lines, -14 lines 0 comments Download
M media/gpu/d3d11_h264_accelerator.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/gpu/d3d11_video_decode_accelerator_win.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M media/gpu/dxva_picture_buffer_win.cc View 6 chunks +9 lines, -7 lines 0 comments Download
M media/gpu/dxva_video_decode_accelerator_win.cc View 26 chunks +41 lines, -38 lines 0 comments Download
M media/gpu/media_foundation_video_encode_accelerator_win.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M media/midi/midi_manager_winrt.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/http/url_security_manager_win.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/backend/print_backend_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M printing/backend/win_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/audio_capturer_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/win/rdp_client_window.cc View 6 chunks +7 lines, -10 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_win.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_win_unittest.cc View 5 chunks +15 lines, -12 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_win_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/win/shell.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M ui/gfx/font_fallback_win.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M ui/gfx/platform_font_win.cc View 8 chunks +10 lines, -10 lines 0 comments Download
M ui/gfx/win/direct_manipulation.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ui/gfx/win/direct_write.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gl/gl_angle_util_win.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/shell_dialogs/select_file_dialog_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/accessibility/native_view_accessibility_win_unittest.cc View 6 chunks +16 lines, -15 lines 0 comments Download

Messages

Total messages: 33 (20 generated)
robliao
scottmg: Please review this CL. Thanks!
3 years, 7 months ago (2017-05-10 17:33:31 UTC) #8
scottmg
wishing-we-had-a-go/rosie-lgtm
3 years, 7 months ago (2017-05-10 17:48:36 UTC) #9
robliao
On 2017/05/10 17:48:36, scottmg wrote: > wishing-we-had-a-go/rosie-lgtm Yeah, Rosie would be very nice here.
3 years, 7 months ago (2017-05-10 18:13:28 UTC) #10
robliao
TBR'ing top-level directory owners for this mechanical rename. Owners: dalecurtis: media/* jam: content/* kbr: gpu/* ...
3 years, 7 months ago (2017-05-10 18:21:33 UTC) #13
Reilly Grant (use Gerrit)
device lgtm
3 years, 7 months ago (2017-05-10 18:24:03 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2870263002/1
3 years, 7 months ago (2017-05-10 18:24:35 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/175078) chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 7 months ago (2017-05-10 18:42:39 UTC) #18
Lei Zhang
chrome/ and printing/ lgtm
3 years, 7 months ago (2017-05-10 20:30:13 UTC) #19
dmazzoni
lgtm for accessibility
3 years, 7 months ago (2017-05-10 21:02:31 UTC) #21
jam
lgtm
3 years, 7 months ago (2017-05-10 22:18:05 UTC) #22
sdefresne
components lgtm
3 years, 7 months ago (2017-05-11 10:16:27 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2870263002/20001
3 years, 7 months ago (2017-05-11 15:01:19 UTC) #30
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 17:14:21 UTC) #33
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/310fa98b9861be3c4b87fd8fd9d9...

Powered by Google App Engine
This is Rietveld 408576698