Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2870253004: Remove |highp_threshold_min| from GLRenderer() (Closed)

Created:
3 years, 7 months ago by Alex Z.
Modified:
3 years, 7 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org, Fady Samuel
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove |highp_threshold_min| from GLRenderer() GLRenderer() takes a RendererSettings which contains a highp_threshold_min as a field and a separate highp_rhreshold_min parameter. In practice, either RendererSettings::highp_threshold_min or a default 0 is passed to GLRenderer(). Therefore, GLRenderer() should use RendererSettings::highp_threshold_min instead. BUG=711146 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2870253004 Cr-Commit-Position: refs/heads/master@{#470615} Committed: https://chromium.googlesource.com/chromium/src/+/72301d1488da45405e793f7d089585f9996c742b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -31 lines) Patch
M cc/output/gl_renderer.h View 2 chunks +1 line, -3 lines 0 comments Download
M cc/output/gl_renderer.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M cc/output/gl_renderer_unittest.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M cc/output/overlay_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/surfaces/display.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/test/pixel_test.h View 2 chunks +4 lines, -8 lines 0 comments Download
M cc/test/pixel_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
Alex Z.
PTAL.
3 years, 7 months ago (2017-05-10 14:48:56 UTC) #4
danakj
Thanks, LGTM
3 years, 7 months ago (2017-05-10 16:40:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2870253004/1
3 years, 7 months ago (2017-05-10 16:51:08 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 16:57:25 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/72301d1488da45405e793f7d0895...

Powered by Google App Engine
This is Rietveld 408576698