Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3250)

Unified Diff: cc/output/gl_renderer.cc

Issue 2870253004: Remove |highp_threshold_min| from GLRenderer() (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/output/gl_renderer.h ('k') | cc/output/gl_renderer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/gl_renderer.cc
diff --git a/cc/output/gl_renderer.cc b/cc/output/gl_renderer.cc
index 7b728ccb258b1ce88cdef9bf1a4cc9f187e1d894..201bf720bed11aa7f42034ba12f3029b7423e811 100644
--- a/cc/output/gl_renderer.cc
+++ b/cc/output/gl_renderer.cc
@@ -375,14 +375,12 @@ class GLRenderer::SyncQuery {
GLRenderer::GLRenderer(const RendererSettings* settings,
OutputSurface* output_surface,
ResourceProvider* resource_provider,
- TextureMailboxDeleter* texture_mailbox_deleter,
- int highp_threshold_min)
+ TextureMailboxDeleter* texture_mailbox_deleter)
: DirectRenderer(settings, output_surface, resource_provider),
shared_geometry_quad_(QuadVertexRect()),
gl_(output_surface->context_provider()->ContextGL()),
context_support_(output_surface->context_provider()->ContextSupport()),
texture_mailbox_deleter_(texture_mailbox_deleter),
- highp_threshold_min_(highp_threshold_min),
gl_composited_texture_quad_border_(
settings->gl_composited_texture_quad_border),
bound_geometry_(NO_BINDING),
@@ -1308,7 +1306,7 @@ void GLRenderer::UpdateRPDQBlendMode(DrawRenderPassDrawQuadParams* params) {
void GLRenderer::ChooseRPDQProgram(DrawRenderPassDrawQuadParams* params) {
TexCoordPrecision tex_coord_precision = TexCoordPrecisionRequired(
- gl_, &highp_threshold_cache_, highp_threshold_min_,
+ gl_, &highp_threshold_cache_, settings_->highp_threshold_min,
params->quad->shared_quad_state->visible_quad_layer_rect.bottom_right());
BlendMode shader_blend_mode =
@@ -1893,7 +1891,8 @@ void GLRenderer::DrawContentQuadAA(const ContentDrawQuadBase* quad,
float vertex_tex_scale_y = tile_rect.height() / clamp_geom_rect.height();
TexCoordPrecision tex_coord_precision = TexCoordPrecisionRequired(
- gl_, &highp_threshold_cache_, highp_threshold_min_, quad->texture_size);
+ gl_, &highp_threshold_cache_, settings_->highp_threshold_min,
+ quad->texture_size);
auto local_quad = gfx::QuadF(gfx::RectF(tile_rect));
float edge[24];
@@ -1994,7 +1993,8 @@ void GLRenderer::DrawContentQuadNoAA(const ContentDrawQuadBase* quad,
}
TexCoordPrecision tex_coord_precision = TexCoordPrecisionRequired(
- gl_, &highp_threshold_cache_, highp_threshold_min_, quad->texture_size);
+ gl_, &highp_threshold_cache_, settings_->highp_threshold_min,
+ quad->texture_size);
SetUseProgram(
ProgramKey::Tile(tex_coord_precision, sampler, NO_AA,
@@ -2054,7 +2054,7 @@ void GLRenderer::DrawYUVVideoQuad(const YUVVideoDrawQuad* quad,
SetBlendEnabled(quad->ShouldDrawWithBlending());
TexCoordPrecision tex_coord_precision = TexCoordPrecisionRequired(
- gl_, &highp_threshold_cache_, highp_threshold_min_,
+ gl_, &highp_threshold_cache_, settings_->highp_threshold_min,
quad->shared_quad_state->visible_quad_layer_rect.bottom_right());
YUVAlphaTextureMode alpha_texture_mode = quad->a_plane_resource_id()
? YUV_HAS_ALPHA_TEXTURE
@@ -2225,7 +2225,7 @@ void GLRenderer::DrawStreamVideoQuad(const StreamVideoDrawQuad* quad,
.egl_image_external);
TexCoordPrecision tex_coord_precision = TexCoordPrecisionRequired(
- gl_, &highp_threshold_cache_, highp_threshold_min_,
+ gl_, &highp_threshold_cache_, settings_->highp_threshold_min,
quad->shared_quad_state->visible_quad_layer_rect.bottom_right());
ResourceProvider::ScopedReadLockGL lock(resource_provider_,
@@ -2363,7 +2363,7 @@ void GLRenderer::EnqueueTextureQuad(const TextureDrawQuad* quad,
}
TexCoordPrecision tex_coord_precision = TexCoordPrecisionRequired(
- gl_, &highp_threshold_cache_, highp_threshold_min_,
+ gl_, &highp_threshold_cache_, settings_->highp_threshold_min,
quad->shared_quad_state->visible_quad_layer_rect.bottom_right());
ResourceProvider::ScopedReadLockGL lock(resource_provider_,
« no previous file with comments | « cc/output/gl_renderer.h ('k') | cc/output/gl_renderer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698