Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 2870203002: Implement chrome://view-http-cache with network service. (Closed)

Created:
3 years, 7 months ago by jam
Modified:
3 years, 7 months ago
Reviewers:
Tom Sepez, mmenke
CC:
chromium-reviews, asanka, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, Randy Smith (Not in Mondays), yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), jkarlin, gavinp
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement chrome://view-http-cache with network service. BUG=717714 Review-Url: https://codereview.chromium.org/2870203002 Cr-Commit-Position: refs/heads/master@{#470978} Committed: https://chromium.googlesource.com/chromium/src/+/7f2980a6dacefd6a9458ab717f51634d51b00890

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase and add test #

Total comments: 8

Patch Set 3 : rebase and add test #

Total comments: 4

Patch Set 4 : review comments and sync #

Patch Set 5 : fix memory leak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -12 lines) Patch
M content/browser/net/view_http_cache_job_factory.cc View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
A content/browser/webui/web_ui_browsertest.cc View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
M content/browser/webui/web_ui_url_loader_factory.cc View 1 2 3 3 chunks +19 lines, -3 lines 0 comments Download
M content/common/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A content/common/network_service.mojom View 1 chunk +13 lines, -0 lines 0 comments Download
M content/network/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M content/network/DEPS View 2 chunks +2 lines, -0 lines 0 comments Download
A content/network/cache_url_loader.h View 1 2 3 1 chunk +23 lines, -0 lines 0 comments Download
A content/network/cache_url_loader.cc View 1 2 3 1 chunk +96 lines, -0 lines 0 comments Download
M content/network/manifest.json View 1 chunk +3 lines, -0 lines 0 comments Download
M content/network/network_service.h View 3 chunks +15 lines, -3 lines 0 comments Download
M content/network/network_service.cc View 3 chunks +20 lines, -4 lines 0 comments Download
M content/public/app/mojo/content_browser_manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M content/test/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 54 (36 generated)
jam
Tom: mojom & manifest Matt: the rest
3 years, 7 months ago (2017-05-09 20:53:19 UTC) #5
mmenke
On 2017/05/09 20:53:19, jam wrote: > Tom: mojom & manifest > Matt: the rest Could ...
3 years, 7 months ago (2017-05-09 21:00:10 UTC) #7
mmenke
[+jkarlin, +gavinp]: Just FYI.
3 years, 7 months ago (2017-05-09 21:01:55 UTC) #8
jam
On 2017/05/09 21:00:10, mmenke wrote: > On 2017/05/09 20:53:19, jam wrote: > > Tom: mojom ...
3 years, 7 months ago (2017-05-09 21:09:04 UTC) #9
Tom Sepez
lgtm https://codereview.chromium.org/2870203002/diff/1/content/common/network_service.mojom File content/common/network_service.mojom (right): https://codereview.chromium.org/2870203002/diff/1/content/common/network_service.mojom#newcode9 content/common/network_service.mojom:9: // Browser interface to the network service. nit: ...
3 years, 7 months ago (2017-05-09 21:10:29 UTC) #10
mmenke
On 2017/05/09 21:09:04, jam wrote: > On 2017/05/09 21:00:10, mmenke wrote: > > On 2017/05/09 ...
3 years, 7 months ago (2017-05-09 21:16:03 UTC) #11
jam
On 2017/05/09 21:16:03, mmenke wrote: > On 2017/05/09 21:09:04, jam wrote: > > On 2017/05/09 ...
3 years, 7 months ago (2017-05-09 21:52:01 UTC) #14
mmenke
I don't think I can sign off on a 150 line CL without a single ...
3 years, 7 months ago (2017-05-09 23:28:07 UTC) #15
mmenke
Thanks so much for the test! This seems pretty reasonable. The ownership model seems a ...
3 years, 7 months ago (2017-05-10 18:52:30 UTC) #27
mmenke
https://codereview.chromium.org/2870203002/diff/60001/content/network/cache_url_loader.cc File content/network/cache_url_loader.cc (right): https://codereview.chromium.org/2870203002/diff/60001/content/network/cache_url_loader.cc#newcode46 content/network/cache_url_loader.cc:46: DataAvailable(rv); Is it safe to call delete this in ...
3 years, 7 months ago (2017-05-10 19:01:53 UTC) #28
jam
https://codereview.chromium.org/2870203002/diff/40001/content/browser/webui/web_ui_url_loader_factory.cc File content/browser/webui/web_ui_url_loader_factory.cc (right): https://codereview.chromium.org/2870203002/diff/40001/content/browser/webui/web_ui_url_loader_factory.cc#newcode253 content/browser/webui/web_ui_url_loader_factory.cc:253: } else if (request.url.host_piece() == kChromeUIBlobInternalsHost) { On 2017/05/10 ...
3 years, 7 months ago (2017-05-10 22:02:53 UTC) #34
mmenke
LGTM https://codereview.chromium.org/2870203002/diff/40001/content/network/cache_url_loader.cc File content/network/cache_url_loader.cc (right): https://codereview.chromium.org/2870203002/diff/40001/content/network/cache_url_loader.cc#newcode65 content/network/cache_url_loader.cc:65: mojo::common::BlockingCopyFromString(data_, data_pipe.producer_handle)); On 2017/05/10 22:02:53, jam wrote: > ...
3 years, 7 months ago (2017-05-10 22:42:36 UTC) #35
jam
https://codereview.chromium.org/2870203002/diff/1/content/common/network_service.mojom File content/common/network_service.mojom (right): https://codereview.chromium.org/2870203002/diff/1/content/common/network_service.mojom#newcode9 content/common/network_service.mojom:9: // Browser interface to the network service. On 2017/05/09 ...
3 years, 7 months ago (2017-05-10 23:05:26 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2870203002/100001
3 years, 7 months ago (2017-05-10 23:06:43 UTC) #41
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/367699)
3 years, 7 months ago (2017-05-11 03:57:20 UTC) #43
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2870203002/120001
3 years, 7 months ago (2017-05-11 14:47:18 UTC) #48
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2870203002/120001
3 years, 7 months ago (2017-05-11 15:46:46 UTC) #51
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 16:43:07 UTC) #54
Message was sent while issue was closed.
Committed patchset #5 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/7f2980a6dacefd6a9458ab717f51...

Powered by Google App Engine
This is Rietveld 408576698