Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Unified Diff: content/browser/webui/web_ui_url_loader_factory.cc

Issue 2870203002: Implement chrome://view-http-cache with network service. (Closed)
Patch Set: fix memory leak Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/webui/web_ui_browsertest.cc ('k') | content/common/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/webui/web_ui_url_loader_factory.cc
diff --git a/content/browser/webui/web_ui_url_loader_factory.cc b/content/browser/webui/web_ui_url_loader_factory.cc
index d73b5167a2eccd908bf98b3ab97c82187e4ce2a8..a349bd942423407f454545a8d4aabe483a8c0517 100644
--- a/content/browser/webui/web_ui_url_loader_factory.cc
+++ b/content/browser/webui/web_ui_url_loader_factory.cc
@@ -20,12 +20,16 @@
#include "content/browser/webui/network_error_url_loader.h"
#include "content/browser/webui/url_data_manager_backend.h"
#include "content/browser/webui/url_data_source_impl.h"
+#include "content/common/network_service.mojom.h"
#include "content/public/browser/browser_context.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/render_process_host.h"
#include "content/public/browser/web_contents.h"
+#include "content/public/common/service_manager_connection.h"
+#include "content/public/common/service_names.mojom.h"
#include "content/public/common/url_constants.h"
#include "mojo/public/cpp/bindings/binding_set.h"
+#include "services/service_manager/public/cpp/connector.h"
#include "third_party/zlib/google/compression_utils.h"
#include "ui/base/template_expressions.h"
@@ -241,6 +245,14 @@ class WebUIURLLoaderFactory : public mojom::URLLoaderFactory,
const ResourceRequest& request,
mojom::URLLoaderClientPtr client) override {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
+ if (request.url.host_piece() == kChromeUINetworkViewCacheHost) {
+ mojom::NetworkServicePtr network_service;
+ ServiceManagerConnection::GetForProcess()->GetConnector()->BindInterface(
+ mojom::kNetworkServiceName, &network_service);
+ network_service->HandleViewCacheRequest(request, std::move(client));
+ return;
+ }
+
if (request.url.host_piece() == kChromeUIBlobInternalsHost) {
BrowserThread::PostTask(
BrowserThread::IO, FROM_HERE,
@@ -249,11 +261,15 @@ class WebUIURLLoaderFactory : public mojom::URLLoaderFactory,
base::Unretained(
ChromeBlobStorageContext::GetFor(browser_context_))));
return;
- } else if (request.url.host_piece() == kChromeUINetworkErrorHost ||
- request.url.host_piece() == kChromeUIDinoHost) {
+ }
+
+ if (request.url.host_piece() == kChromeUINetworkErrorHost ||
+ request.url.host_piece() == kChromeUIDinoHost) {
StartNetworkErrorsURLLoader(request, std::move(client));
return;
- } else if (request.url.host_piece() == kChromeUIHistogramHost) {
+ }
+
+ if (request.url.host_piece() == kChromeUIHistogramHost) {
StartHistogramInternalsURLLoader(request, std::move(client));
return;
}
« no previous file with comments | « content/browser/webui/web_ui_browsertest.cc ('k') | content/common/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698