Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 2869973002: [Merge M59] arg: Fix removing shortcuts on package update. (Closed)

Created:
3 years, 7 months ago by khmel
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

[Merge M59] arg: Fix removing shortcuts on package update. TEST=unit tests extented. Manually, updated test app via adb and its shorcuts were left in app launcher BUG=718625 BUG=b/34749664 TBR=xiyuan@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2860243002 Cr-Commit-Position: refs/heads/master@{#469529} (cherry picked from commit 9984205426901dece21078e03eb68d4c7ef1fa07) Review-Url: https://codereview.chromium.org/2869973002 Cr-Commit-Position: refs/branch-heads/3071@{#468} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/765f43f5304b773f50c44c69675a1d956e3784af

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -8 lines) Patch
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.h View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc View 3 chunks +14 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_unittest.cc View 6 chunks +24 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2869973002/1
3 years, 7 months ago (2017-05-08 21:44:56 UTC) #4
commit-bot: I haz the power
Failed to commit the patch.
3 years, 7 months ago (2017-05-08 21:47:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2869973002/1
3 years, 7 months ago (2017-05-08 21:50:08 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 21:51:21 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/765f43f5304b773f50c44c69675a...

Powered by Google App Engine
This is Rietveld 408576698