arc: Fix removing shortcuts on package update.

arc: Fix removing shortcuts on package update.

TEST=unit tests extented. Manually, updated test app via adb and
     its shorcuts were left in app launcher
BUG=718625
BUG=b/34749664

Review-Url: https://codereview.chromium.org/2860243002
Cr-Commit-Position: refs/heads/master@{#469529}
Committed: https://chromium.googlesource.com/chromium/src/+/9984205426901dece21078e03eb68d4c7ef1fa07

[khmel, 2017-05-04 22:40:59]

The CQ bit was checked by khmel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 22:41:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[khmel, 2017-05-04 22:49:04]

khmel@chromium.org changed reviewers:
+ xiyuan@chromium.org

[khmel, 2017-05-04 22:49:05]

Hi Xiyuan,

PTAL

Thanks!

https://codereview.chromium.org/2860243002/diff/1/chrome/browser/ui/app_list/...
File chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc (right):

https://codereview.chromium.org/2860243002/diff/1/chrome/browser/ui/app_list/...
chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc:1058:
GetAppsForPackage(package_name);
That was actual problem. We did grab here apps + shortcuts and compare with new
set of apps only.

https://codereview.chromium.org/2860243002/diff/1/chrome/browser/ui/app_list/...
File chrome/browser/ui/app_list/arc/arc_app_list_prefs.h (right):

https://codereview.chromium.org/2860243002/diff/1/chrome/browser/ui/app_list/...
chrome/browser/ui/app_list/arc/arc_app_list_prefs.h:244:
std::unordered_set<std::string> GetAppsForPackage(
There are 2 public usages of this function. However it have meaning app only

[commit-bot: I haz the power, 2017-05-04 23:11:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 23:11:09]

Dry run: This issue passed the CQ dry run.

[xiyuan, 2017-05-04 23:15:33]

lgtm

https://codereview.chromium.org/2860243002/diff/1/chrome/browser/ui/app_list/...
File chrome/browser/ui/app_list/arc/arc_app_unittest.cc (right):

https://codereview.chromium.org/2860243002/diff/1/chrome/browser/ui/app_list/...
chrome/browser/ui/app_list/arc/arc_app_unittest.cc:1383: // Adding package is
requred to safely call SendPackageUninstalled.
nit: requred -> required

[khmel, 2017-05-04 23:18:03]

Thanks for quick review!

https://codereview.chromium.org/2860243002/diff/1/chrome/browser/ui/app_list/...
File chrome/browser/ui/app_list/arc/arc_app_unittest.cc (right):

https://codereview.chromium.org/2860243002/diff/1/chrome/browser/ui/app_list/...
chrome/browser/ui/app_list/arc/arc_app_unittest.cc:1383: // Adding package is
requred to safely call SendPackageUninstalled.
On 2017/05/04 23:15:33, xiyuan wrote:
> nit: requred -> required

Done.

[khmel, 2017-05-04 23:18:05]

The CQ bit was checked by khmel@chromium.org

[khmel, 2017-05-04 23:18:06]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2860243002/#ps20001
(title: "typo fix")

[commit-bot: I haz the power, 2017-05-04 23:18:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 23:57:47]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493939885948710,
"parent_rev": "bf2f59c91d37384ee7196d42b081aa70b458518b", "commit_rev":
"9984205426901dece21078e03eb68d4c7ef1fa07"}

[commit-bot: I haz the power, 2017-05-04 23:59:03]

Description was changed from

==========
arc: Fix removing shortcuts on package update.

TEST=unit tests extented. Manually, updated test app via adb and
     its shorcuts were left in app launcher
BUG=718625
BUG=b/34749664
==========

to

==========
arc: Fix removing shortcuts on package update.

TEST=unit tests extented. Manually, updated test app via adb and
     its shorcuts were left in app launcher
BUG=718625
BUG=b/34749664

Review-Url: https://codereview.chromium.org/2860243002
Cr-Commit-Position: refs/heads/master@{#469529}
Committed:
https://chromium.googlesource.com/chromium/src/+/9984205426901dece21078e03eb6...
==========

[commit-bot: I haz the power, 2017-05-04 23:59:04]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9984205426901dece21078e03eb6...