Issue 2869933003: ProcessSingletonPosix: don't CHECK if trying to connect to existing process with too long socket sy…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2869933003: ProcessSingletonPosix: don't CHECK if trying to connect to existing process with too long socket sy… (Closed)

Created:
3 years, 7 months ago by mattm

Modified:
3 years, 7 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3029

Project:
chromium

Visibility:
Public.

ProcessSingletonPosix: don't CHECK if trying to connect to existing process with too long socket symlink target. Also don't leave a dangling socket symlink if startup fails because the tmpdir path is too long. BUG=698759 Review-Url: https://codereview.chromium.org/2811173003 Cr-Commit-Position: refs/heads/master@{#464549} (cherry picked from commit 916edf164d5d8a60473dcdcf46e13ab0a646d7f3) Review-Url: https://codereview.chromium.org/2869933003 . Cr-Commit-Position: refs/branch-heads/3029@{#824} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/8bd8b3c759f5846a4c28cde8c97b55bd0a424724

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -9 lines)			Patch
	M	chrome/browser/process_singleton_posix.cc	View		6 chunks	+23 lines, -9 lines	0 comments	Download
	M	chrome/browser/process_singleton_posix_unittest.cc	View		1 chunk	+18 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

mattm

3 years, 7 months ago (2017-05-08 21:58:34 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8bd8b3c759f5846a4c28cde8c97b55bd0a424724.