ProcessSingletonPosix: don't CHECK if trying to connect to existing process with too long socket sy…

ProcessSingletonPosix: don't CHECK if trying to connect to existing process with too long socket symlink target.

Also don't leave a dangling socket symlink if startup fails because the tmpdir path is too long.

BUG=698759
Review-Url: https://codereview.chromium.org/2811173003
Cr-Commit-Position: refs/heads/master@{#464549}
Committed: https://chromium.googlesource.com/chromium/src/+/916edf164d5d8a60473dcdcf46e13ab0a646d7f3

[mattm, 2017-04-12 00:40:05]

mattm@chromium.org changed reviewers:
+ thakis@chromium.org

[mattm, 2017-04-12 00:40:06]

People who hit the case of a too long TMPDIR would get stuck with a symlink to
the too-long path that causes any subsequent attempts to start chrome to fail,
even if the too long TMPDIR problem is fixed. This fixes that.

[Nico, 2017-04-13 15:54:36]

lgtm

https://codereview.chromium.org/2811173003/diff/1/chrome/browser/process_sing...
File chrome/browser/process_singleton_posix.cc (right):

https://codereview.chromium.org/2811173003/diff/1/chrome/browser/process_sing...
chrome/browser/process_singleton_posix.cc:992:
SetupSocket(socket_target_path.value(), &sock, &addr);
add comment why it's ok if this returns false

[mattm, 2017-04-13 20:15:27]

https://codereview.chromium.org/2811173003/diff/1/chrome/browser/process_sing...
File chrome/browser/process_singleton_posix.cc (right):

https://codereview.chromium.org/2811173003/diff/1/chrome/browser/process_sing...
chrome/browser/process_singleton_posix.cc:992:
SetupSocket(socket_target_path.value(), &sock, &addr);
On 2017/04/13 15:54:36, Nico wrote:
> add comment why it's ok if this returns false

This one can't return false (SetupSocket does a CHECK internally). I updated the
comment to be more specific about that, and added comments on the SetupSockAddr
calls.

[mattm, 2017-04-13 20:30:22]

Description was changed from

==========
ProcessSingletonLinux: don't CHECK if trying to connect to existing process with
too long socket symlink target.

Also don't leave a dangling socket symlink if startup fails because the tmpdir
path is too long.

BUG=698759
==========

to

==========
ProcessSingletonPosix: don't CHECK if trying to connect to existing process with
too long socket symlink target.

Also don't leave a dangling socket symlink if startup fails because the tmpdir
path is too long.

BUG=698759
==========

[mattm, 2017-04-13 20:31:13]

The CQ bit was checked by mattm@chromium.org

[mattm, 2017-04-13 20:31:14]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2811173003/#ps20001
(title: "updated comments")

[commit-bot: I haz the power, 2017-04-13 20:32:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 21:26:56]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492115473572660,
"parent_rev": "08debb3333b06d4bf652e72df8720582ee5d957e", "commit_rev":
"916edf164d5d8a60473dcdcf46e13ab0a646d7f3"}

[commit-bot: I haz the power, 2017-04-13 21:27:45]

Description was changed from

==========
ProcessSingletonPosix: don't CHECK if trying to connect to existing process with
too long socket symlink target.

Also don't leave a dangling socket symlink if startup fails because the tmpdir
path is too long.

BUG=698759
==========

to

==========
ProcessSingletonPosix: don't CHECK if trying to connect to existing process with
too long socket symlink target.

Also don't leave a dangling socket symlink if startup fails because the tmpdir
path is too long.

BUG=698759

Review-Url: https://codereview.chromium.org/2811173003
Cr-Commit-Position: refs/heads/master@{#464549}
Committed:
https://chromium.googlesource.com/chromium/src/+/916edf164d5d8a60473dcdcf46e1...
==========

[commit-bot: I haz the power, 2017-04-13 21:27:48]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/916edf164d5d8a60473dcdcf46e1...