Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Issue 2869893005: Clamp RunInfo::num_characters when shaping ranges with context (Closed)

Created:
3 years, 7 months ago by kojii
Modified:
3 years, 7 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, dshwang, drott+blinkwatch_chromium.org, krit, fmalita+watch_chromium.org, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Clamp RunInfo::num_characters when shaping ranges with context HarfBuzzShaper::ShapeSegment clamps ShapeResult::num_characters but RunInfo::num_characters was not clamped. This patch applies the same clamping to RunInfo::num_characters. BUG=689155 Review-Url: https://codereview.chromium.org/2869893005 Cr-Commit-Position: refs/heads/master@{#470371} Committed: https://chromium.googlesource.com/chromium/src/+/84d8af49b69b6ab89bde2d657b96c5f280fd439c

Patch Set 1 #

Messages

Total messages: 14 (10 generated)
kojii
PTAL. Found this during the line breaker integration.
3 years, 7 months ago (2017-05-09 14:20:29 UTC) #6
eae
Nice catch, thank you. LGTM
3 years, 7 months ago (2017-05-09 15:16:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2869893005/1
3 years, 7 months ago (2017-05-09 17:19:26 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 17:38:28 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/84d8af49b69b6ab89bde2d657b96...

Powered by Google App Engine
This is Rietveld 408576698