third_party/WebKit/Source/platform/fonts/shaping/ShapeResultTestInfo.h - Issue 2869893005: Clamp RunInfo::num_characters when shaping ranges with context

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/ShapeResultTestInfo.h

Issue 2869893005: Clamp RunInfo::num_characters when shaping ranges with context (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp ('k') | third_party/WebKit/Source/platform/fonts/shaping/ShapeResultTestInfo.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/shaping/ShapeResultTestInfo.h

diff --git a/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultTestInfo.h b/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultTestInfo.h

index a0f1ae026461c9225dd52a9eae6e2d8334643b56..f95d54301a49133171b962c8b7d23a4401bbd643 100644

--- a/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultTestInfo.h

+++ b/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultTestInfo.h

@@ -19,6 +19,11 @@ class PLATFORM_EXPORT ShapeResultTestInfo : public ShapeResult {

unsigned& start_index,

unsigned& num_glyphs,

hb_script_t&) const;

+ bool RunInfoForTesting(unsigned run_index,

+ unsigned& start_index,

+ unsigned& num_characters,

+ unsigned& num_glyphs,

+ hb_script_t&) const;

uint16_t GlyphForTesting(unsigned run_index, size_t glyph_index) const;

float AdvanceForTesting(unsigned run_index, size_t glyph_index) const;

SimpleFontData* FontDataForTesting(unsigned run_index) const;