Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2869763002: Change strings for update permissions infobar. (Closed)

Created:
3 years, 7 months ago by benwells
Modified:
3 years, 7 months ago
Reviewers:
Ted C, raymes
CC:
chromium-reviews, srahim+watch_chromium.org, agrieve+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change strings for update permissions infobar. The strings were brief but confusing. BUG=710362 Review-Url: https://codereview.chromium.org/2869763002 Cr-Commit-Position: refs/heads/master@{#473488} Committed: https://chromium.googlesource.com/chromium/src/+/36ecf1abe91cd116d144aeb82b821bd201587916

Patch Set 1 #

Total comments: 3

Patch Set 2 : With final strings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M chrome/android/java/strings/android_chrome_strings.grd View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/app/chromium_strings.grd View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 26 (13 generated)
benwells
I'll be tackling the multiple permissions string (the worst) in a separate CL, as we'll ...
3 years, 7 months ago (2017-05-08 12:55:01 UTC) #4
raymes
lgtm https://codereview.chromium.org/2869763002/diff/1/chrome/android/java/strings/android_chrome_strings.grd File chrome/android/java/strings/android_chrome_strings.grd (right): https://codereview.chromium.org/2869763002/diff/1/chrome/android/java/strings/android_chrome_strings.grd#newcode1640 chrome/android/java/strings/android_chrome_strings.grd:1640: Chrome needs access to to your location to ...
3 years, 7 months ago (2017-05-08 22:19:44 UTC) #7
benwells
https://codereview.chromium.org/2869763002/diff/1/chrome/android/java/strings/android_chrome_strings.grd File chrome/android/java/strings/android_chrome_strings.grd (right): https://codereview.chromium.org/2869763002/diff/1/chrome/android/java/strings/android_chrome_strings.grd#newcode1640 chrome/android/java/strings/android_chrome_strings.grd:1640: Chrome needs access to to your location to share ...
3 years, 7 months ago (2017-05-09 07:41:10 UTC) #8
benwells
The mic and camera strings, as well as the button, have all been revised. Please ...
3 years, 7 months ago (2017-05-17 03:57:56 UTC) #9
raymes
lgtm
3 years, 7 months ago (2017-05-17 04:46:43 UTC) #10
benwells
+tedchoc for android_chrome_strings owner
3 years, 7 months ago (2017-05-17 04:47:21 UTC) #12
Ted C
lgtm
3 years, 7 months ago (2017-05-17 13:59:20 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2869763002/20001
3 years, 7 months ago (2017-05-17 23:20:45 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/429924)
3 years, 7 months ago (2017-05-18 05:28:16 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2869763002/20001
3 years, 7 months ago (2017-05-19 20:27:41 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/298675)
3 years, 7 months ago (2017-05-19 23:30:04 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2869763002/20001
3 years, 7 months ago (2017-05-21 22:20:03 UTC) #23
commit-bot: I haz the power
3 years, 7 months ago (2017-05-21 23:04:02 UTC) #26
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/36ecf1abe91cd116d144aeb82b82...

Powered by Google App Engine
This is Rietveld 408576698