Don't enable a direct manipulation layer.

Don't enable a direct manipulation layer.

It appears that the direct manipulation layer being added no longer
provides any benefit and only causes issues. I've confirmed both on a
Surface and a Dell laptop with high precision touchpads that removing
the layer doesn't change any behavior.

Just disable the layer for now keeping the code around. I will remove the
code after we've had this out in the field for a bit.

BUG=647038
Review-Url: https://codereview.chromium.org/2869643003
Cr-Commit-Position: refs/heads/master@{#470410}
Committed: https://chromium.googlesource.com/chromium/src/+/20407a59ca3f29bfe7ca6a0cdea8fe95a7482ab5

[dtapuska, 2017-05-08 18:36:45]

dtapuska@chromium.org changed reviewers:
+ anantha@chromium.org, sky@chromium.org

[sky, 2017-05-08 21:45:57]

https://codereview.chromium.org/2869643003/diff/1/ui/gfx/win/direct_manipulat...
File ui/gfx/win/direct_manipulation.cc (right):

https://codereview.chromium.org/2869643003/diff/1/ui/gfx/win/direct_manipulat...
ui/gfx/win/direct_manipulation.cc:17: // TODO(dtapuska): Remove the Direct
Manipulation code it only causes
How about changing this function to unconditionally return null for now?

[dtapuska, 2017-05-09 13:32:31]

https://codereview.chromium.org/2869643003/diff/1/ui/gfx/win/direct_manipulat...
File ui/gfx/win/direct_manipulation.cc (right):

https://codereview.chromium.org/2869643003/diff/1/ui/gfx/win/direct_manipulat...
ui/gfx/win/direct_manipulation.cc:17: // TODO(dtapuska): Remove the Direct
Manipulation code it only causes
On 2017/05/08 21:45:57, sky wrote:
> How about changing this function to unconditionally return null for now?

Done.

[sky, 2017-05-09 17:23:15]

LGTM - why not remove all the code now though?

[dtapuska, 2017-05-09 18:15:26]

On 2017/05/09 17:23:15, sky wrote:
> LGTM - why not remove all the code now though?

I wanted to get some feedback to make sure I haven't broken anything before
performing surgery on this code.

[dtapuska, 2017-05-09 18:15:29]

The CQ bit was checked by dtapuska@chromium.org

[commit-bot: I haz the power, 2017-05-09 18:16:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 19:37:11]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494353729582160,
"parent_rev": "35b5da108fd0ae4c66c7665a09d0a3d682ce25e5", "commit_rev":
"20407a59ca3f29bfe7ca6a0cdea8fe95a7482ab5"}

[commit-bot: I haz the power, 2017-05-09 19:37:23]

Description was changed from

==========
Don't enable a direct manipulation layer.

It appears that the direct manipulation layer being added no longer
provides any benefit and only causes issues. I've confirmed both on a
Surface and a Dell laptop with high precision touchpads that removing
the layer doesn't change any behavior.

Just disable the layer for now keeping the code around. I will remove the
code after we've had this out in the field for a bit.

BUG=647038
==========

to

==========
Don't enable a direct manipulation layer.

It appears that the direct manipulation layer being added no longer
provides any benefit and only causes issues. I've confirmed both on a
Surface and a Dell laptop with high precision touchpads that removing
the layer doesn't change any behavior.

Just disable the layer for now keeping the code around. I will remove the
code after we've had this out in the field for a bit.

BUG=647038

Review-Url: https://codereview.chromium.org/2869643003
Cr-Commit-Position: refs/heads/master@{#470410}
Committed:
https://chromium.googlesource.com/chromium/src/+/20407a59ca3f29bfe7ca6a0cdea8...
==========

[commit-bot: I haz the power, 2017-05-09 19:37:25]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/20407a59ca3f29bfe7ca6a0cdea8...