Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Unified Diff: ui/gfx/win/direct_manipulation.cc

Issue 2869643003: Don't enable a direct manipulation layer. (Closed)
Patch Set: Remove conditional Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/win/direct_manipulation.cc
diff --git a/ui/gfx/win/direct_manipulation.cc b/ui/gfx/win/direct_manipulation.cc
index c6572f9c3d428f9aa325f019bd5c48f8075198df..7f6a0949f035b01ca9e6803e184537112d412af5 100644
--- a/ui/gfx/win/direct_manipulation.cc
+++ b/ui/gfx/win/direct_manipulation.cc
@@ -12,12 +12,11 @@ namespace win {
// static
std::unique_ptr<DirectManipulationHelper>
DirectManipulationHelper::CreateInstance() {
- std::unique_ptr<DirectManipulationHelper> instance;
-
- if (base::win::GetVersion() >= base::win::VERSION_WIN10)
- instance.reset(new DirectManipulationHelper);
-
- return instance;
+ // TODO(dtapuska): Do not create a DirectManipulationHelper on any windows
+ // versions as it only causes issues. High Precision Touchpad events seem to
+ // always be sent to apps with recent Windows 10 versions. This class should
+ // eventually be removed. See crbug.com/647038.
+ return nullptr;
}
DirectManipulationHelper::DirectManipulationHelper() {}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698