Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 286943002: [VS Addin] Add more information when compile tests fail. (Closed)

Created:
6 years, 7 months ago by Sam Clegg
Modified:
6 years, 7 months ago
Reviewers:
binji
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

[VS Addin] Add more information when compile tests fail. These tests can fail when the build verbosity in VS is set too low (which was happening on the bots). This change doesn't fix it but at least gives more information about what might be going wrong. R=binji@chromium.org Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1572

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M visual_studio/NativeClientVSAddIn/UnitTests/BaseCompileTest.cs View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Sam Clegg
This change should appear make the bot green again as I logged in a changed ...
6 years, 7 months ago (2014-05-14 22:48:04 UTC) #1
binji
lgtm
6 years, 7 months ago (2014-05-14 22:54:54 UTC) #2
Sam Clegg
6 years, 7 months ago (2014-05-14 22:57:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r1572 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698