Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: visual_studio/NativeClientVSAddIn/UnitTests/BaseCompileTest.cs

Issue 286943002: [VS Addin] Add more information when compile tests fail. (Closed) Base URL: https://nativeclient-sdk.googlecode.com/svn/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: visual_studio/NativeClientVSAddIn/UnitTests/BaseCompileTest.cs
diff --git a/visual_studio/NativeClientVSAddIn/UnitTests/BaseCompileTest.cs b/visual_studio/NativeClientVSAddIn/UnitTests/BaseCompileTest.cs
index be46d2d15ec6093d0090f1970e7d68c46bfa4bc4..04fc1bfcf6284e012310ee3445d570c0d3c8ad02 100644
--- a/visual_studio/NativeClientVSAddIn/UnitTests/BaseCompileTest.cs
+++ b/visual_studio/NativeClientVSAddIn/UnitTests/BaseCompileTest.cs
@@ -76,7 +76,9 @@ namespace UnitTests
/// <param name="platformName">Platform name.</param>
private void TryCompile(string configName, string platformName)
{
- string failFormat = "Project compile failed for {0} platform {1} config."
+ string failFormat = "Project compile failed for {0} platform {1} config.\n"
+ + "If this test fails it could be because the build output"
+ + "is set to Minimal or below.\n"
+ "Build output: {2}";
string cygwinWarningFormat = "Did not pass cygwin nodosfilewarning environment var to"
+ " tools Platform: {0}, configuration: {1}";
@@ -89,6 +91,11 @@ namespace UnitTests
string compileOutput = TestUtilities.GetPaneText(
dte_.ToolWindows.OutputWindow.OutputWindowPanes.Item("Build"));
+
+ // Check for "Build succeeded" in the output pane. This only works if
+ // the visual studio output verbosity is set to Normal or above.
+ // TODO(sbc): find some other way to verify success or at least verify
+ // that the build verbosity is set to Normal or above.
Assert.IsTrue(
compileOutput.Contains("Build succeeded.", ignoreCase),
string.Format(failFormat, platformName, configName, compileOutput));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698