Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2869353002:
[css-grid] Use "Ahem" instead of "ahem" on grid layout tests (Closed)
|
Created:
3 years, 7 months ago by Manuel Rego Modified:
3 years, 7 months ago CC:
chromium-reviews, blink-reviews, svillar, jfernandez, Manuel Rego Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[css-grid] Use "Ahem" instead of "ahem" on grid layout tests
This is a tentative fix for an issue we're having on Windows
when running tests on random order.
BUG=718717
Review-Url: https://codereview.chromium.org/2869353002
Cr-Commit-Position: refs/heads/master@{#470817}
Committed: https://chromium.googlesource.com/chromium/src/+/cfd0c5e26f717dd1f27c3e17c2f031c30a26951e
Patch Set 1 #
Messages
Total messages: 32 (16 generated)
rego@igalia.com changed reviewers: + jfernandez@igalia.com, svillar@igalia.com, tansell@chromium.org
I think it'd be nice to try this, so we can verify if the issue on Windows random order is this or not.
lgtm
The CQ bit was checked by rego@igalia.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rego@igalia.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rego@igalia.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rego@igalia.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rego@igalia.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rego@igalia.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rego@igalia.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494477583858450, "parent_rev":
"fc8efc725e151ffc2f2584b75d9c52fd16cf3721", "commit_rev":
"cfd0c5e26f717dd1f27c3e17c2f031c30a26951e"}
Message was sent while issue was closed.
Description was changed from ========== [css-grid] Use "Ahem" instead of "ahem" on grid layout tests This is a tentative fix for an issue we're having on Windows when running tests on random order. BUG=718717 ========== to ========== [css-grid] Use "Ahem" instead of "ahem" on grid layout tests This is a tentative fix for an issue we're having on Windows when running tests on random order. BUG=718717 Review-Url: https://codereview.chromium.org/2869353002 Cr-Commit-Position: refs/heads/master@{#470817} Committed: https://chromium.googlesource.com/chromium/src/+/cfd0c5e26f717dd1f27c3e17c2f0... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/cfd0c5e26f717dd1f27c3e17c2f0... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
