Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2869333002:
Initialize test configuration to a default value. (Closed)
|
Created:
3 years, 7 months ago by Jia Modified:
3 years, 7 months ago CC:
chromium-reviews, darin-cc_chromium.org, einbinder+watch-test-runner_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionInitialize test configuration to a default value.
BlinkTestRunner::OnSetTestConfiguration should be
called to init test_config_ before any method using
test_config_ is run. However, this is not always
enforced by the test runner/controller as discovered
by clusterfuzz (see bug below). Hence this cl
initializes test_config_ to a default value to ensure
it is never a null ptr.
BUG=714028
Review-Url: https://codereview.chromium.org/2869333002
Cr-Commit-Position: refs/heads/master@{#470913}
Committed: https://chromium.googlesource.com/chromium/src/+/4d916411aa57de16c95e693cf9dd33d7e3bf65ee
Patch Set 1 #
Total comments: 4
Patch Set 2 : Add a comment to explain with default value of test_config's enable_pixel_dumping is true. #Patch Set 3 : Change default value of enable_pixel_dumping to true. #Patch Set 4 : Run cl format. #Messages
Total messages: 36 (25 generated)
Description was changed from ========== Initialize test configurations to a default value. BUG=714028 ========== to ========== BlinkTestRunner::OnSetTestConfiguration should be called to init test_config_ before any method using test_config_ is run. However, this is not always enforced by the test runner/controller as discovered by clusterfuzz (see bug below). Hence this cl initializes test_config_ to a default value to ensure it is never a null ptr. BUG=714028 ==========
The CQ bit was checked by jiameng@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
jiameng@chromium.org changed reviewers: + sammc@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by jiameng@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM. Please format your description to fit in 72 columns, starting with a one-line summary (matching the CL title) followed by a blank line. https://codereview.chromium.org/2869333002/diff/1/content/shell/renderer/layo... File content/shell/renderer/layout_test/blink_test_runner.cc (right): https://codereview.chromium.org/2869333002/diff/1/content/shell/renderer/layo... content/shell/renderer/layout_test/blink_test_runner.cc:259: test_config_->enable_pixel_dumping = true; Why does this default to true?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== BlinkTestRunner::OnSetTestConfiguration should be called to init test_config_ before any method using test_config_ is run. However, this is not always enforced by the test runner/controller as discovered by clusterfuzz (see bug below). Hence this cl initializes test_config_ to a default value to ensure it is never a null ptr. BUG=714028 ========== to ========== Initialize test configuration to a default value. BlinkTestRunner::OnSetTestConfiguration should be called to init test_config_ before any method using test_config_ is run. However, this is not always enforced by the test runner/controller as discovered by clusterfuzz (see bug below). Hence this cl initializes test_config_ to a default value to ensure it is never a null ptr. BUG=714028 ==========
The CQ bit was checked by jiameng@chromium.org to run a CQ dry run
Thanks a lot! All done. PTAL. https://codereview.chromium.org/2869333002/diff/1/content/shell/renderer/layo... File content/shell/renderer/layout_test/blink_test_runner.cc (right): https://codereview.chromium.org/2869333002/diff/1/content/shell/renderer/layo... content/shell/renderer/layout_test/blink_test_runner.cc:259: test_config_->enable_pixel_dumping = true; On 2017/05/10 07:55:44, Sam McNally wrote: > Why does this default to true? Because the old struct ShellTestConfiguration default initializes this field to true. Please see https://codereview.chromium.org/2594913002 shell_test_configuration.cc
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2869333002/diff/1/content/shell/renderer/layo... File content/shell/renderer/layout_test/blink_test_runner.cc (right): https://codereview.chromium.org/2869333002/diff/1/content/shell/renderer/layo... content/shell/renderer/layout_test/blink_test_runner.cc:259: test_config_->enable_pixel_dumping = true; On 2017/05/10 22:55:29, Jia wrote: > On 2017/05/10 07:55:44, Sam McNally wrote: > > Why does this default to true? > > Because the old struct ShellTestConfiguration default initializes this field to > true. Please see https://codereview.chromium.org/2594913002 > shell_test_configuration.cc In that case, maybe it makes sense to set that as the default in the mojom. See https://chromium.googlesource.com/chromium/src/+/master/mojo/public/tools/bin....
https://codereview.chromium.org/2869333002/diff/1/content/shell/renderer/layo... File content/shell/renderer/layout_test/blink_test_runner.cc (right): https://codereview.chromium.org/2869333002/diff/1/content/shell/renderer/layo... content/shell/renderer/layout_test/blink_test_runner.cc:259: test_config_->enable_pixel_dumping = true; On 2017/05/10 23:37:13, Sam McNally wrote: > On 2017/05/10 22:55:29, Jia wrote: > > On 2017/05/10 07:55:44, Sam McNally wrote: > > > Why does this default to true? > > > > Because the old struct ShellTestConfiguration default initializes this field > to > > true. Please see https://codereview.chromium.org/2594913002 > > shell_test_configuration.cc > > In that case, maybe it makes sense to set that as the default in the mojom. See > https://chromium.googlesource.com/chromium/src/+/master/mojo/public/tools/bin.... Done. Thanks for pointing out!
Since we set the default value in the mojom file, we won't need the override in the blink_test_runner any more.
The CQ bit was checked by jiameng@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
jiameng@chromium.org changed reviewers: + mkwst@chromium.org
mkwst@chromium.org: Please review changes in
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by jiameng@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM.
The CQ bit was checked by jiameng@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494499841234270,
"parent_rev": "bcbc0c40b5987b07425a9bad2f9dadfeb4612182", "commit_rev":
"4d916411aa57de16c95e693cf9dd33d7e3bf65ee"}
Message was sent while issue was closed.
Description was changed from ========== Initialize test configuration to a default value. BlinkTestRunner::OnSetTestConfiguration should be called to init test_config_ before any method using test_config_ is run. However, this is not always enforced by the test runner/controller as discovered by clusterfuzz (see bug below). Hence this cl initializes test_config_ to a default value to ensure it is never a null ptr. BUG=714028 ========== to ========== Initialize test configuration to a default value. BlinkTestRunner::OnSetTestConfiguration should be called to init test_config_ before any method using test_config_ is run. However, this is not always enforced by the test runner/controller as discovered by clusterfuzz (see bug below). Hence this cl initializes test_config_ to a default value to ensure it is never a null ptr. BUG=714028 Review-Url: https://codereview.chromium.org/2869333002 Cr-Commit-Position: refs/heads/master@{#470913} Committed: https://chromium.googlesource.com/chromium/src/+/4d916411aa57de16c95e693cf9dd... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/4d916411aa57de16c95e693cf9dd... |
