Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Side by Side Diff: content/shell/renderer/layout_test/blink_test_runner.cc

Issue 2869333002: Initialize test configuration to a default value. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/shell/renderer/layout_test/blink_test_runner.h" 5 #include "content/shell/renderer/layout_test/blink_test_runner.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <algorithm> 9 #include <algorithm>
10 #include <clocale> 10 #include <clocale>
(...skipping 234 matching lines...) Expand 10 before | Expand all | Expand 10 after
245 .Append(FILE_PATH_LITERAL("LayoutTests/")) 245 .Append(FILE_PATH_LITERAL("LayoutTests/"))
246 .AppendASCII(path); 246 .AppendASCII(path);
247 return WebURL(net::FilePathToFileURL(new_path)); 247 return WebURL(net::FilePathToFileURL(new_path));
248 } 248 }
249 249
250 } // namespace 250 } // namespace
251 251
252 BlinkTestRunner::BlinkTestRunner(RenderView* render_view) 252 BlinkTestRunner::BlinkTestRunner(RenderView* render_view)
253 : RenderViewObserver(render_view), 253 : RenderViewObserver(render_view),
254 RenderViewObserverTracker<BlinkTestRunner>(render_view), 254 RenderViewObserverTracker<BlinkTestRunner>(render_view),
255 test_config_(mojom::ShellTestConfiguration::New()),
255 is_main_window_(false), 256 is_main_window_(false),
256 focus_on_next_commit_(false), 257 focus_on_next_commit_(false),
257 leak_detector_(new LeakDetector(this)) { 258 leak_detector_(new LeakDetector(this)) {
259 test_config_->enable_pixel_dumping = true;
Sam McNally 2017/05/10 07:55:44 Why does this default to true?
Jia 2017/05/10 22:55:29 Because the old struct ShellTestConfiguration defa
Sam McNally 2017/05/10 23:37:13 In that case, maybe it makes sense to set that as
Jia 2017/05/11 00:42:02 Done. Thanks for pointing out!
258 } 260 }
259 261
260 BlinkTestRunner::~BlinkTestRunner() { 262 BlinkTestRunner::~BlinkTestRunner() {
261 } 263 }
262 264
263 // WebTestDelegate ----------------------------------------------------------- 265 // WebTestDelegate -----------------------------------------------------------
264 266
265 void BlinkTestRunner::ClearEditCommand() { 267 void BlinkTestRunner::ClearEditCommand() {
266 render_view()->ClearEditCommands(); 268 render_view()->ClearEditCommands();
267 } 269 }
(...skipping 791 matching lines...) Expand 10 before | Expand all | Expand 10 after
1059 void BlinkTestRunner::ReportLeakDetectionResult( 1061 void BlinkTestRunner::ReportLeakDetectionResult(
1060 const LeakDetectionResult& report) { 1062 const LeakDetectionResult& report) {
1061 Send(new ShellViewHostMsg_LeakDetectionDone(routing_id(), report)); 1063 Send(new ShellViewHostMsg_LeakDetectionDone(routing_id(), report));
1062 } 1064 }
1063 1065
1064 void BlinkTestRunner::OnDestruct() { 1066 void BlinkTestRunner::OnDestruct() {
1065 delete this; 1067 delete this;
1066 } 1068 }
1067 1069
1068 } // namespace content 1070 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698