Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Unified Diff: chrome/browser/safe_browsing/chrome_password_protection_service.h

Issue 2869253002: Add UMA metrics to phishguard pings (Closed)
Patch Set: resolve comments on histograms.xml Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/chrome_password_protection_service.h
diff --git a/chrome/browser/safe_browsing/chrome_password_protection_service.h b/chrome/browser/safe_browsing/chrome_password_protection_service.h
index 77bbc2fefeccffc4840389a055465301288b59a8..68e25b9fb6de1ffa5fa097d51574eb10865beab2 100644
--- a/chrome/browser/safe_browsing/chrome_password_protection_service.h
+++ b/chrome/browser/safe_browsing/chrome_password_protection_service.h
@@ -36,9 +36,11 @@ class ChromePasswordProtectionService : public PasswordProtectionService {
bool IsIncognito() override;
// Checks if Finch config allows sending pings to Safe Browsing Server.
+ // If not, indicated its reason by modifying |reason|.
// |feature| should be either kLowReputationPinging or
// kProtectedPasswordEntryPinging.
- bool IsPingingEnabled(const base::Feature& feature) override;
+ bool IsPingingEnabled(const base::Feature& feature,
+ RequestOutcome* reason) override;
// If user enabled history syncing.
bool IsHistorySyncEnabled() override;

Powered by Google App Engine
This is Rietveld 408576698