Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

Issue 2869253002: Add UMA metrics to phishguard pings (Closed)
Patch Set: resolve comments on histograms.xml Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
diff --git a/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc b/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
index a1216c847230960cddb021b41095b0b8df8c66e2..fe53e8bae98e6a1cd70dac3de0eb187d8c6df147 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
+++ b/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
@@ -83,9 +83,9 @@ class MockPasswordProtectionService
safe_browsing::LoginReputationClientRequest::Frame*));
MOCK_METHOD0(IsExtendedReporting, bool());
MOCK_METHOD0(IsIncognito, bool());
- MOCK_METHOD1(IsPingingEnabled, bool(const base::Feature&));
+ MOCK_METHOD2(IsPingingEnabled, bool(const base::Feature&, RequestOutcome*));
MOCK_METHOD0(IsHistorySyncEnabled, bool());
- MOCK_METHOD3(MaybeStartLowReputationRequest,
+ MOCK_METHOD3(MaybeStartPasswordFieldOnFocusRequest,
void(const GURL&, const GURL&, const GURL&));
private:
@@ -610,14 +610,14 @@ TEST_F(ChromePasswordManagerClientTest, CanShowBubbleOnURL) {
#if defined(SAFE_BROWSING_DB_LOCAL)
TEST_F(ChromePasswordManagerClientTest,
- VerifyMaybeStartLowReputationRequestCalled) {
+ VerifyMaybeStartPasswordFieldOnFocusRequestCalled) {
std::unique_ptr<WebContents> test_web_contents(
content::WebContentsTester::CreateTestWebContents(
web_contents()->GetBrowserContext(), nullptr));
std::unique_ptr<MockChromePasswordManagerClient> client(
new MockChromePasswordManagerClient(test_web_contents.get()));
EXPECT_CALL(*client->password_protection_service(),
- MaybeStartLowReputationRequest(_, _, _))
+ MaybeStartPasswordFieldOnFocusRequest(_, _, _))
.Times(1);
client->CheckSafeBrowsingReputation(GURL("http://foo.com/submit"),
GURL("http://foo.com/iframe.html"));

Powered by Google App Engine
This is Rietveld 408576698