Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Side by Side Diff: chrome/browser/safe_browsing/chrome_password_protection_service.h

Issue 2869253002: Add UMA metrics to phishguard pings (Closed)
Patch Set: resolve comments on histograms.xml Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SAFE_BROWSING_CHROME_PASSWORD_PROTECTION_SERVICE_H_ 5 #ifndef CHROME_BROWSER_SAFE_BROWSING_CHROME_PASSWORD_PROTECTION_SERVICE_H_
6 #define CHROME_BROWSER_SAFE_BROWSING_CHROME_PASSWORD_PROTECTION_SERVICE_H_ 6 #define CHROME_BROWSER_SAFE_BROWSING_CHROME_PASSWORD_PROTECTION_SERVICE_H_
7 7
8 #include "components/safe_browsing/password_protection/password_protection_servi ce.h" 8 #include "components/safe_browsing/password_protection/password_protection_servi ce.h"
9 9
10 class Profile; 10 class Profile;
(...skipping 18 matching lines...) Expand all
29 // info into |frame|. 29 // info into |frame|.
30 void FillReferrerChain(const GURL& event_url, 30 void FillReferrerChain(const GURL& event_url,
31 int event_tab_id, 31 int event_tab_id,
32 LoginReputationClientRequest::Frame* frame) override; 32 LoginReputationClientRequest::Frame* frame) override;
33 33
34 bool IsExtendedReporting() override; 34 bool IsExtendedReporting() override;
35 35
36 bool IsIncognito() override; 36 bool IsIncognito() override;
37 37
38 // Checks if Finch config allows sending pings to Safe Browsing Server. 38 // Checks if Finch config allows sending pings to Safe Browsing Server.
39 // If not, indicated its reason by modifying |reason|.
39 // |feature| should be either kLowReputationPinging or 40 // |feature| should be either kLowReputationPinging or
40 // kProtectedPasswordEntryPinging. 41 // kProtectedPasswordEntryPinging.
41 bool IsPingingEnabled(const base::Feature& feature) override; 42 bool IsPingingEnabled(const base::Feature& feature,
43 RequestOutcome* reason) override;
42 44
43 // If user enabled history syncing. 45 // If user enabled history syncing.
44 bool IsHistorySyncEnabled() override; 46 bool IsHistorySyncEnabled() override;
45 47
46 FRIEND_TEST_ALL_PREFIXES( 48 FRIEND_TEST_ALL_PREFIXES(
47 ChromePasswordProtectionServiceTest, 49 ChromePasswordProtectionServiceTest,
48 VerifyFinchControlForLowReputationPingSBEROnlyNoIncognito); 50 VerifyFinchControlForLowReputationPingSBEROnlyNoIncognito);
49 FRIEND_TEST_ALL_PREFIXES( 51 FRIEND_TEST_ALL_PREFIXES(
50 ChromePasswordProtectionServiceTest, 52 ChromePasswordProtectionServiceTest,
51 VerifyFinchControlForLowReputationPingSBERAndHistorySyncNoIncognito); 53 VerifyFinchControlForLowReputationPingSBERAndHistorySyncNoIncognito);
(...skipping 10 matching lines...) Expand all
62 // Profile associated with this instance. 64 // Profile associated with this instance.
63 Profile* profile_; 65 Profile* profile_;
64 scoped_refptr<SafeBrowsingNavigationObserverManager> 66 scoped_refptr<SafeBrowsingNavigationObserverManager>
65 navigation_observer_manager_; 67 navigation_observer_manager_;
66 DISALLOW_COPY_AND_ASSIGN(ChromePasswordProtectionService); 68 DISALLOW_COPY_AND_ASSIGN(ChromePasswordProtectionService);
67 }; 69 };
68 70
69 } // namespace safe_browsing 71 } // namespace safe_browsing
70 72
71 #endif // CHROME_BROWSER_SAFE_BROWSING_CHROME_PASSWORD_PROTECTION_SERVICE_H_ 73 #endif // CHROME_BROWSER_SAFE_BROWSING_CHROME_PASSWORD_PROTECTION_SERVICE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698