[Devtools] Added product entry tests for network

[Devtools] Added product entry tests for network

This patch adds product registry/entry test for network panel to ensure
product entries give basic good results along with tests to make sure
frames are attribution is taken into account.

R=dgozman,pfeldman
BUG=720133

[allada, 2017-05-10 22:25:01]

PTL

https://codereview.chromium.org/2879503002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
(right):

https://codereview.chromium.org/2879503002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js:436:
InspectorTest.waitEventListener = function(event, obj, condition = undefined)
There are a few places in this file that could use this function. I want to
convert to use this function instead (which is why I added the "condition"
callback), but in a followup.

https://codereview.chromium.org/2879503002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/http/tests/inspector/page-mock.js (right):

https://codereview.chromium.org/2879503002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/page-mock.js:282: return
Promise.resolve().then(() => this._onMessage.call(null,
JSON.stringify(message)));
These were in non-deterministic order, so I went to setImmidiate instead.

[allada, 2017-05-10 22:25:08]

Patchset #1 (id:1) has been deleted

[pfeldman, 2017-05-10 22:37:46]

lgtm

[dgozman, 2017-05-10 22:57:14]

https://codereview.chromium.org/2879503002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
(right):

https://codereview.chromium.org/2879503002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js:436:
InspectorTest.waitEventListener = function(event, obj, condition = undefined)
On 2017/05/10 22:25:01, allada wrote:
> There are a few places in this file that could use this function. I want to
> convert to use this function instead (which is why I added the "condition"
> callback), but in a followup.

Paul is adding .once(), will it work in most cases?

https://codereview.chromium.org/2879503002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/http/tests/inspector/page-mock.js (right):

https://codereview.chromium.org/2879503002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/page-mock.js:129:
console.assert(!this._pageGetResourceTreeHasRan, "Cannot add frames after
getResourceTreeTree has ran.");
InspectorTest.completeTest here so we see the test failing.

https://codereview.chromium.org/2879503002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/page-mock.js:133: loaderId:
this._mainFrame.loaderId,
loaderId should be unique.

https://codereview.chromium.org/2879503002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/page-mock.js:145: * @return
{!Promise<string>}
Why return Promise? I think we should waitForRequest instead, using the same
helper you'd use for real backend test.

https://codereview.chromium.org/2879503002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/page-mock.js:147:
requestWillBeSent(url, frame) {
Let's call this sendXHR and issue responseReceived and loadingFinished as well.

https://codereview.chromium.org/2879503002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/page-mock.js:226: resources:
[]
Let's report html resource. Or add TODO for it.

https://codereview.chromium.org/2879503002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/inspector/network/network-product-entry.html
(right):

https://codereview.chromium.org/2879503002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/network/network-product-entry.html:54:
var request = InspectorTest.networkLog.requestForId(networkManager, requestId);
Use InspectorTest.findRequestsByURLPattern to make it similar to integration
test.

[allada, 2017-05-10 23:30:11]

Patchset #2 (id:40001) has been deleted

[dgozman, 2017-07-15 05:53:12]

Description was changed from

==========
[Devtools] Added product entry tests for network

This patch adds product registry/entry test for network panel to ensure
product entries give basic good results along with tests to make sure
frames are attribution is taken into account.

R=dgozman,pfeldman
BUG=720133
==========

to

==========
[Devtools] Added product entry tests for network

This patch adds product registry/entry test for network panel to ensure
product entries give basic good results along with tests to make sure
frames are attribution is taken into account.

R=dgozman,pfeldman
BUG=720133
==========

[dgozman, 2017-07-15 05:53:12]

dgozman@chromium.org changed reviewers:
- dgozman@chromium.org