Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2869163002: Refactor dbus SessionManagerInterface.StartArcInterface (Closed)

Created:
3 years, 7 months ago by xc
Modified:
3 years, 6 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, oshima+watch_chromium.org, hashimoto+watch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, victorhsieh+watch_chromium.org, yusukes+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor dbus SessionManagerInterface.StartArcInterface Now we use a proto message as parameter for the dbus interface to start ARC instances. BUG=b:37989086 TEST=locally build and flash, start ARC Review-Url: https://codereview.chromium.org/2869163002 Cr-Commit-Position: refs/heads/master@{#475722} Committed: https://chromium.googlesource.com/chromium/src/+/2f57e3f7ccd26bba9a22394f5bf2741a0682b510

Patch Set 1 #

Patch Set 2 : update names #

Total comments: 4

Patch Set 3 : fix comments #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -10 lines) Patch
M chromeos/BUILD.gn View 1 2 3 2 chunks +9 lines, -0 lines 0 comments Download
M chromeos/dbus/session_manager_client.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/dbus/session_manager_client.cc View 1 2 3 2 chunks +10 lines, -5 lines 0 comments Download
M components/arc/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M components/arc/arc_session.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 27 (14 generated)
xc
yusukes@chromium.org: Please review changes in component/arc/* derat@chromium.org: Please review changes in chromeos/*
3 years, 7 months ago (2017-05-11 01:07:18 UTC) #2
Yusuke Sato
thanks for the work. arc/ lgtm, but please do not send this to CQ until ...
3 years, 7 months ago (2017-05-11 01:17:24 UTC) #5
Daniel Erat
note that you'll need to update the cros_system_api revision in DEPS in order to pull ...
3 years, 7 months ago (2017-05-11 02:41:51 UTC) #8
xiaohuic
On 2017/05/11 02:41:51, Daniel Erat wrote: > note that you'll need to update the cros_system_api ...
3 years, 7 months ago (2017-05-11 16:46:47 UTC) #9
xc
Deps are rolled. PTAL https://codereview.chromium.org/2869163002/diff/20001/components/arc/arc_session.cc File components/arc/arc_session.cc (right): https://codereview.chromium.org/2869163002/diff/20001/components/arc/arc_session.cc#newcode366 components/arc/arc_session.cc:366: bool skip_boot_completed_broadcast = On 2017/05/11 ...
3 years, 7 months ago (2017-05-15 18:01:07 UTC) #10
xc
ping
3 years, 6 months ago (2017-05-30 19:53:24 UTC) #11
Daniel Erat
lgtm thanks for the ping, and sorry i missed the update.
3 years, 6 months ago (2017-05-30 19:57:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2869163002/40001
3 years, 6 months ago (2017-05-30 20:00:42 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/221757) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 6 months ago (2017-05-30 20:03:30 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2869163002/60001
3 years, 6 months ago (2017-05-30 20:44:02 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/467747)
3 years, 6 months ago (2017-05-30 23:43:08 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2869163002/60001
3 years, 6 months ago (2017-05-30 23:55:17 UTC) #24
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 01:30:10 UTC) #27
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/2f57e3f7ccd26bba9a22394f5bf2...

Powered by Google App Engine
This is Rietveld 408576698