Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: chromeos/dbus/session_manager_client.cc

Issue 2869163002: Refactor dbus SessionManagerInterface.StartArcInterface (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/dbus/session_manager_client.h ('k') | components/arc/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/session_manager_client.cc
diff --git a/chromeos/dbus/session_manager_client.cc b/chromeos/dbus/session_manager_client.cc
index 2184de5cea2a3eaec151a46735ef2acb55e4b4a8..c4cda060abb44545bf561b10195547361d23a53f 100644
--- a/chromeos/dbus/session_manager_client.cc
+++ b/chromeos/dbus/session_manager_client.cc
@@ -25,6 +25,7 @@
#include "chromeos/cryptohome/cryptohome_parameters.h"
#include "chromeos/dbus/blocking_method_caller.h"
#include "chromeos/dbus/cryptohome_client.h"
+#include "chromeos/dbus/login_manager/arc.pb.h"
#include "components/policy/proto/device_management_backend.pb.h"
#include "crypto/sha2.h"
#include "dbus/bus.h"
@@ -402,16 +403,20 @@ class SessionManagerClientImpl : public SessionManagerClient {
}
void StartArcInstance(const cryptohome::Identification& cryptohome_id,
- bool disable_boot_completed_broadcast,
- bool enable_vendor_privileged,
+ bool skip_boot_completed_broadcast,
+ bool scan_vendor_priv_app,
const StartArcInstanceCallback& callback) override {
dbus::MethodCall method_call(
login_manager::kSessionManagerInterface,
login_manager::kSessionManagerStartArcInstance);
dbus::MessageWriter writer(&method_call);
- writer.AppendString(cryptohome_id.id());
- writer.AppendBool(disable_boot_completed_broadcast);
- writer.AppendBool(enable_vendor_privileged);
+
+ login_manager::StartArcInstanceRequest request;
+ request.set_account_id(cryptohome_id.id());
+ request.set_skip_boot_completed_broadcast(skip_boot_completed_broadcast);
+ request.set_scan_vendor_priv_app(scan_vendor_priv_app);
+ writer.AppendProtoAsArrayOfBytes(request);
+
session_manager_proxy_->CallMethodWithErrorCallback(
&method_call, dbus::ObjectProxy::TIMEOUT_USE_DEFAULT,
base::Bind(&SessionManagerClientImpl::OnStartArcInstanceSucceeded,
« no previous file with comments | « chromeos/dbus/session_manager_client.h ('k') | components/arc/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698