Convert server to use RangeFactory

Convert server to use RangeFactory

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/98e8f17b9606e909eafd399303d28ff649ed0a02

[Brian Wilkerson, 2017-05-09 15:57:26]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2017-05-09 16:04:15]

LGTM

https://codereview.chromium.org/2869083002/diff/1/pkg/analyzer_plugin/lib/uti...
File pkg/analyzer_plugin/lib/utilities/range_factory.dart (right):

https://codereview.chromium.org/2869083002/diff/1/pkg/analyzer_plugin/lib/uti...
pkg/analyzer_plugin/lib/utilities/range_factory.dart:95: SourceRange
offsetEndIndex(int offset, int endIndex) {
Drop "Index" for consistency with other methods, like "startEnd"?

[Brian Wilkerson, 2017-05-09 16:51:56]

https://codereview.chromium.org/2869083002/diff/1/pkg/analyzer_plugin/lib/uti...
File pkg/analyzer_plugin/lib/utilities/range_factory.dart (right):

https://codereview.chromium.org/2869083002/diff/1/pkg/analyzer_plugin/lib/uti...
pkg/analyzer_plugin/lib/utilities/range_factory.dart:95: SourceRange
offsetEndIndex(int offset, int endIndex) {
> Drop "Index" for consistency with other methods, like "startEnd"?

So far, "end" means that 'end' will be invoked on the corresponding
SyntacticEntity (and "start" means 'start' will be invoked). But in this case
the parameter is an 'int'. The other places we take an 'int' we use "length"
(because it's used as the length of the range). I was trying to find something
that would be consistent with that pattern.

If I drop the "Index", then I can't write a method to create a range from the
start of an entity to a given ending offset because it would want to be named
startEnd, and then the name has two meanings. And I'd rather not make the
parameter's type 'Object' because it doesn't help the user. I'd use overloading
if Dart supported it, but...

Thoughts?

[Brian Wilkerson, 2017-05-09 17:08:18]

Description was changed from

==========
Convert server to use RangeFactory
==========

to

==========
Convert server to use RangeFactory

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/98e8f17b9606e909eafd399303d28ff649ed0a02
==========

[Brian Wilkerson, 2017-05-09 17:08:19]

Committed patchset #1 (id:1) manually as
98e8f17b9606e909eafd399303d28ff649ed0a02 (presubmit successful).