Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/rename_import.dart

Issue 2869083002: Convert server to use RangeFactory (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/refactoring/rename_import.dart
diff --git a/pkg/analysis_server/lib/src/services/refactoring/rename_import.dart b/pkg/analysis_server/lib/src/services/refactoring/rename_import.dart
index fa4b8bc3676ac24b10f0276813aae3bfd5f5d941..bb397ef8e86c3a57f00da10f1133d93161725ace 100644
--- a/pkg/analysis_server/lib/src/services/refactoring/rename_import.dart
+++ b/pkg/analysis_server/lib/src/services/refactoring/rename_import.dart
@@ -7,7 +7,6 @@ library services.src.refactoring.rename_import;
import 'dart:async';
import 'package:analysis_server/src/protocol_server.dart';
-import 'package:analysis_server/src/services/correction/source_range.dart';
import 'package:analysis_server/src/services/correction/status.dart';
import 'package:analysis_server/src/services/refactoring/naming_conventions.dart';
import 'package:analysis_server/src/services/refactoring/refactoring.dart';
@@ -18,6 +17,7 @@ import 'package:analyzer/dart/ast/ast.dart';
import 'package:analyzer/dart/element/element.dart';
import 'package:analyzer/src/dart/ast/utilities.dart';
import 'package:analyzer/src/generated/source.dart';
+import 'package:analyzer_plugin/utilities/range_factory.dart';
/**
* A [Refactoring] for renaming [ImportElement]s.
@@ -56,17 +56,15 @@ class RenameImportRefactoringImpl extends RenameRefactoringImpl {
if (newName.isEmpty) {
int uriEnd = element.uriEnd;
int prefixEnd = element.prefixOffset + prefix.nameLength;
- SourceRange range = rangeStartEnd(uriEnd, prefixEnd);
- edit = newSourceEdit_range(range, "");
+ edit = newSourceEdit_range(range.offsetEndIndex(uriEnd, prefixEnd), "");
} else {
if (prefix == null) {
- SourceRange range = rangeStartLength(element.uriEnd, 0);
- edit = newSourceEdit_range(range, " as $newName");
+ edit = newSourceEdit_range(
+ new SourceRange(element.uriEnd, 0), " as $newName");
} else {
int offset = element.prefixOffset;
int length = prefix.nameLength;
- SourceRange range = rangeStartLength(offset, length);
- edit = newSourceEdit_range(range, newName);
+ edit = newSourceEdit_range(new SourceRange(offset, length), newName);
}
}
if (edit != null) {

Powered by Google App Engine
This is Rietveld 408576698