Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2069)

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart

Issue 2869083002: Convert server to use RangeFactory (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart
diff --git a/pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart b/pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart
index e23c60c1d32613d8207cedd976ab135b61751ffa..0bbe817843523e4fc9eda7e0d5da4d1f27640cf3 100644
--- a/pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart
+++ b/pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart
@@ -7,7 +7,6 @@ library services.src.refactoring.rename_constructor;
import 'dart:async';
import 'package:analysis_server/src/protocol_server.dart' hide Element;
-import 'package:analysis_server/src/services/correction/source_range.dart';
import 'package:analysis_server/src/services/correction/status.dart';
import 'package:analysis_server/src/services/correction/util.dart';
import 'package:analysis_server/src/services/refactoring/naming_conventions.dart';
@@ -22,6 +21,7 @@ import 'package:analyzer/dart/element/element.dart';
import 'package:analyzer/src/dart/element/ast_provider.dart';
import 'package:analyzer/src/generated/java_core.dart';
import 'package:analyzer/src/generated/source.dart';
+import 'package:analyzer_plugin/utilities/range_factory.dart';
/**
* A [Refactoring] for renaming [ConstructorElement]s.
@@ -95,10 +95,11 @@ class RenameConstructorRefactoringImpl extends RenameRefactoringImpl {
SourceReference _createDeclarationReference() {
SourceRange sourceRange;
- if (element.periodOffset != null) {
- sourceRange = rangeStartEnd(element.periodOffset, element.nameEnd);
+ int offset = element.periodOffset;
+ if (offset != null) {
+ sourceRange = range.offsetEndIndex(offset, element.nameEnd);
} else {
- sourceRange = rangeStartLength(element.nameEnd, 0);
+ sourceRange = new SourceRange(element.nameEnd, 0);
}
return new SourceReference(new SearchMatchImpl(
element.context,

Powered by Google App Engine
This is Rietveld 408576698