Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2869063002:
mac: Don't transfer background color to new tabs (Closed)
Descriptionmac: Don't transfer background color to new tabs
New tabs should be created with the NTP background color, which is what
happens on Mac.
On Aura, this doesn't happen, and the workaround is to open the new tab
with the color from the previous page.
This workaround has no place on Mac, so disable it.
BUG=719230
Review-Url: https://codereview.chromium.org/2869063002
Cr-Commit-Position: refs/heads/master@{#470509}
Committed: https://chromium.googlesource.com/chromium/src/+/39db31b0859157dc9848bb25181d50b553a72ddf
Patch Set 1 #Patch Set 2 : disable test too #Patch Set 3 : s/DISABLE/DISABLED/g #
Messages
Total messages: 23 (17 generated)
Description was changed from ========== mac: Don't transfer background color to new tabs New tabs should be created with the NTP background color, which is what happens on Mac. On Aura, this doesn't happen, and the workaround is to open the new tab with the color from the previous page. This workaround has no place on Mac, so disable it. BUG=719230 ========== to ========== mac: Don't transfer background color to new tabs New tabs should be created with the NTP background color, which is what happens on Mac. On Aura, this doesn't happen, and the workaround is to open the new tab with the color from the previous page. This workaround has no place on Mac, so disable it. BUG=719230 ==========
ccameron@chromium.org changed reviewers: + sky@chromium.org
The CQ bit was checked by ccameron@chromium.org to run a CQ dry run
ptal
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by ccameron@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Where does Mac code set the background color to the NTP color?
On 2017/05/09 17:22:29, sky wrote: > Where does Mac code set the background color to the NTP color? This is done in TabContentController https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/tab_contents/tab... The critical place to hook up is in -[NSView viewWillMoveToWindow] at https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/tab_contents/tab...
The CQ bit was checked by ccameron@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Thanks for the pointer. LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by ccameron@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494395977023790,
"parent_rev": "ce973093cfd98991db01f779cc049868d89e8d8a", "commit_rev":
"39db31b0859157dc9848bb25181d50b553a72ddf"}
Message was sent while issue was closed.
Description was changed from ========== mac: Don't transfer background color to new tabs New tabs should be created with the NTP background color, which is what happens on Mac. On Aura, this doesn't happen, and the workaround is to open the new tab with the color from the previous page. This workaround has no place on Mac, so disable it. BUG=719230 ========== to ========== mac: Don't transfer background color to new tabs New tabs should be created with the NTP background color, which is what happens on Mac. On Aura, this doesn't happen, and the workaround is to open the new tab with the color from the previous page. This workaround has no place on Mac, so disable it. BUG=719230 Review-Url: https://codereview.chromium.org/2869063002 Cr-Commit-Position: refs/heads/master@{#470509} Committed: https://chromium.googlesource.com/chromium/src/+/39db31b0859157dc9848bb25181d... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/39db31b0859157dc9848bb25181d... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
