Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1046)

Unified Diff: chrome/browser/ui/browser.cc

Issue 2869063002: mac: Don't transfer background color to new tabs (Closed)
Patch Set: s/DISABLE/DISABLED/g Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/browser_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index 87bda12a8864d1a21c8cc277d822862a03c026f2..c5c74c9498acf75fee5f56d24796002aed01358c 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -1035,6 +1035,11 @@ void Browser::ActiveTabChanged(WebContents* old_contents,
WebContents* new_contents,
int index,
int reason) {
+// Mac correctly sets the initial background color of new tabs to the theme
+// background color, so it does not need this block of code. Aura should
+// implement this as well.
+// https://crbug.com/719230
+#if !defined(OS_MACOSX)
// Copies the background color from an old WebContents to a new one that
// replaces it on the screen. This allows the new WebContents to use the
// old one's background color as the starting background color, before having
@@ -1050,6 +1055,7 @@ void Browser::ActiveTabChanged(WebContents* old_contents,
if (old_view && new_view)
new_view->SetBackgroundColor(old_view->background_color());
}
+#endif
base::RecordAction(UserMetricsAction("ActiveTabChanged"));
« no previous file with comments | « no previous file | chrome/browser/ui/browser_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698