Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2868873002: Photo Picker Dialog: A bit of polish. (Closed)

Created:
3 years, 7 months ago by Finnur
Modified:
3 years, 7 months ago
Reviewers:
Theresa
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Photo Picker Dialog: A bit of polish. - Enable single-selection. - Don't show scrim until photo has loaded. - Fade in the images on load. BUG=656015 Review-Url: https://codereview.chromium.org/2868873002 Cr-Commit-Position: refs/heads/master@{#470274} Committed: https://chromium.googlesource.com/chromium/src/+/9dc5991e8182ed6fd79e77c5f158af1a420a23be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerBitmapView.java View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerBitmapViewHolder.java View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerCategoryView.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
Finnur
3 years, 7 months ago (2017-05-08 15:19:43 UTC) #3
Theresa
lgtm
3 years, 7 months ago (2017-05-08 19:37:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2868873002/1
3 years, 7 months ago (2017-05-09 10:45:24 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 10:50:39 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9dc5991e8182ed6fd79e77c5f158...

Powered by Google App Engine
This is Rietveld 408576698