Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3230)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerBitmapView.java

Issue 2868873002: Photo Picker Dialog: A bit of polish. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerBitmapViewHolder.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerBitmapView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerBitmapView.java b/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerBitmapView.java
index 4ae42dae62435c6a9b952c9121f5b52c0c11a112..556087fc9bc10e07160b97caf124d56e4789f3f0 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerBitmapView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerBitmapView.java
@@ -332,8 +332,9 @@ public class PickerBitmapView extends SelectableItemView<PickerBitmap> {
// to show it when nothing is selected and also not on a blank canvas.
mSelectedView.setVisibility(!special && checked ? View.VISIBLE : View.GONE);
mUnselectedView.setVisibility(
- !special && !checked && anySelection ? View.VISIBLE : View.GONE);
- mScrim.setVisibility(!special && !checked && anySelection ? View.VISIBLE : View.GONE);
+ !special && !checked && anySelection && mImageLoaded ? View.VISIBLE : View.GONE);
+ mScrim.setVisibility(
+ !special && !checked && anySelection && mImageLoaded ? View.VISIBLE : View.GONE);
}
private boolean isGalleryTile() {
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerBitmapViewHolder.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698