Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: ui/message_center/views/message_view.cc

Issue 2868833002: Call the parent methods in MessageView::OnPaint, OnFocus, and OnBlur (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/message_center/views/message_view.cc
diff --git a/ui/message_center/views/message_view.cc b/ui/message_center/views/message_view.cc
index 6d5aca2f3b66ab1d30f638f5eeec2e8b68787af0..abc66f3b8fc55ff3168ee48ef34f28686aa2f450 100644
--- a/ui/message_center/views/message_view.cc
+++ b/ui/message_center/views/message_view.cc
@@ -152,15 +152,18 @@ bool MessageView::OnKeyReleased(const ui::KeyEvent& event) {
}
void MessageView::OnPaint(gfx::Canvas* canvas) {
+ views::View::OnPaint(canvas);
yoshiki 2017/05/08 11:22:17 OnPaint draws a border so it's necessary to fix cr
views::Painter::PaintFocusPainter(this, canvas, focus_painter_.get());
}
void MessageView::OnFocus() {
+ views::View::OnFocus();
yoshiki 2017/05/08 11:22:17 OnFocus fires an a11y event so I think it's needed
// We paint a focus indicator.
SchedulePaint();
}
void MessageView::OnBlur() {
+ views::View::OnBlur();
yoshiki 2017/05/08 11:22:17 Actually View::OnBlur() is empty but I added this
// We paint a focus indicator.
SchedulePaint();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698