Re-add delay to PostTask in StartScrollbarPaintTimer()

Re-add delay to PostTask in StartScrollbarPaintTimer()

My previous CL removed 0.1 ms delay from PostTask in
ScrollAnimatorMac::startScrollbarPaintTimer[1] because new PostTask interface
didn't support micro sec delay (type of |delay| was changed from "double" to
"long long"). This seems to give tasks more chances to run before task
cancellation and probably contention happens.

This CL re-adds 1 ms delay (not 0.1 ms because the current PostTask doesn't
support micro sec delay as mentioned above) and confirmed it improved the scroll
animation in the demo page (see the issue).

[1] https://codereview.chromium.org/2514733002/

BUG=713669
Review-Url: https://codereview.chromium.org/2868783006
Cr-Commit-Position: refs/heads/master@{#470823}
Committed: https://chromium.googlesource.com/chromium/src/+/570b67158dabf2d9f10bb12ac68762e973ed63ad

[nhiroki, 2017-05-09 06:39:01]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 06:39:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2017-05-09 06:56:48]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 06:56:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 07:18:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 07:18:04]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[nhiroki, 2017-05-10 05:59:26]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 06:00:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2017-05-10 06:01:08]

Description was changed from

==========
Re-add delay to PostTask in StartScrollbarPaintTimer()

This delay was accidentally removed by the following change:
https://codereview.chromium.org/2514733002

BUG=713669
==========

to

==========
Re-add delay to PostTask in StartScrollbarPaintTimer()

(TODO: Update the CL description)

This 0.1 ms delay was removed by the following change:
https://codereview.chromium.org/2514733002

BUG=713669
==========

[nhiroki, 2017-05-10 06:01:19]

Patchset #1 (id:1) has been deleted

[nhiroki, 2017-05-10 06:01:27]

Patchset #1 (id:20001) has been deleted

[nhiroki, 2017-05-10 06:37:29]

Description was changed from

==========
Re-add delay to PostTask in StartScrollbarPaintTimer()

(TODO: Update the CL description)

This 0.1 ms delay was removed by the following change:
https://codereview.chromium.org/2514733002

BUG=713669
==========

to

==========
Re-add delay to PostTask in StartScrollbarPaintTimer()

My previous change removed 0.1 ms delay from PostTask in
ScrollAnimatorMac::startScrollbarPaintTimer[1] because new PostTask interface
didn't support micro sec delay (type of the delay was changed from "double" to
"long long"). This causes perf regression on scroll animation on MacOS.

This CL re-adds 1 ms delay (not 0.1 ms because the current PostTask doesn't
support micro sec delay as mentioned above) and confirmed it improved the scroll
animation in the demo page (see issue).

[1] https://codereview.chromium.org/2514733002/
[2] https://codereview.chromium.org/2868783006/

BUG=713669
==========

[nhiroki, 2017-05-10 06:39:27]

Description was changed from

==========
Re-add delay to PostTask in StartScrollbarPaintTimer()

My previous change removed 0.1 ms delay from PostTask in
ScrollAnimatorMac::startScrollbarPaintTimer[1] because new PostTask interface
didn't support micro sec delay (type of the delay was changed from "double" to
"long long"). This causes perf regression on scroll animation on MacOS.

This CL re-adds 1 ms delay (not 0.1 ms because the current PostTask doesn't
support micro sec delay as mentioned above) and confirmed it improved the scroll
animation in the demo page (see issue).

[1] https://codereview.chromium.org/2514733002/
[2] https://codereview.chromium.org/2868783006/

BUG=713669
==========

to

==========
Re-add delay to PostTask in StartScrollbarPaintTimer()

My previous CL removed 0.1 ms delay from PostTask in
ScrollAnimatorMac::startScrollbarPaintTimer[1] because new PostTask interface
didn't support micro sec delay (type of |delay| was changed from "double" to
"long long"). This gives scroll animation tasks more chances to run before task
cancellation, and probably task contention happens.

This CL re-adds 1 ms delay (not 0.1 ms because the current PostTask doesn't
support micro sec delay as mentioned above) and confirmed it improved the scroll
animation in the demo page (see the issue).

[1] https://codereview.chromium.org/2514733002/
[2] https://codereview.chromium.org/2868783006/

BUG=713669
==========

[nhiroki, 2017-05-10 06:43:42]

Description was changed from

==========
Re-add delay to PostTask in StartScrollbarPaintTimer()

My previous CL removed 0.1 ms delay from PostTask in
ScrollAnimatorMac::startScrollbarPaintTimer[1] because new PostTask interface
didn't support micro sec delay (type of |delay| was changed from "double" to
"long long"). This gives scroll animation tasks more chances to run before task
cancellation, and probably task contention happens.

This CL re-adds 1 ms delay (not 0.1 ms because the current PostTask doesn't
support micro sec delay as mentioned above) and confirmed it improved the scroll
animation in the demo page (see the issue).

[1] https://codereview.chromium.org/2514733002/
[2] https://codereview.chromium.org/2868783006/

BUG=713669
==========

to

==========
Re-add delay to PostTask in StartScrollbarPaintTimer()

My previous CL removed 0.1 ms delay from PostTask in
ScrollAnimatorMac::startScrollbarPaintTimer[1] because new PostTask interface
didn't support micro sec delay (type of |delay| was changed from "double" to
"long long"). This seems to give tasks more chances to run before task
cancellation and probably contention happens.

This CL re-adds 1 ms delay (not 0.1 ms because the current PostTask doesn't
support micro sec delay as mentioned above) and confirmed it improved the scroll
animation in the demo page (see the issue).

[1] https://codereview.chromium.org/2514733002/
[2] https://codereview.chromium.org/2868783006/

BUG=713669
==========

[nhiroki, 2017-05-10 06:47:28]

nhiroki@chromium.org changed reviewers:
+ bokan@chromium.org, skobes@chromium.org, tzik@chromium.org

[nhiroki, 2017-05-10 06:47:29]

Hi, could you review this?

+tzik@ for PostTask
+bokan@,skobes@ for scrolling

Thanks.

[tzik, 2017-05-10 06:56:15]

lgtm

[nhiroki, 2017-05-10 06:56:58]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 06:57:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 08:17:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 08:17:42]

Dry run: This issue passed the CQ dry run.

[bokan, 2017-05-10 13:26:11]

Your commit self-references this CL in your [2] link.

Otherwise lgtm

[nhiroki, 2017-05-11 04:49:27]

Description was changed from

==========
Re-add delay to PostTask in StartScrollbarPaintTimer()

My previous CL removed 0.1 ms delay from PostTask in
ScrollAnimatorMac::startScrollbarPaintTimer[1] because new PostTask interface
didn't support micro sec delay (type of |delay| was changed from "double" to
"long long"). This seems to give tasks more chances to run before task
cancellation and probably contention happens.

This CL re-adds 1 ms delay (not 0.1 ms because the current PostTask doesn't
support micro sec delay as mentioned above) and confirmed it improved the scroll
animation in the demo page (see the issue).

[1] https://codereview.chromium.org/2514733002/
[2] https://codereview.chromium.org/2868783006/

BUG=713669
==========

to

==========
Re-add delay to PostTask in StartScrollbarPaintTimer()

My previous CL removed 0.1 ms delay from PostTask in
ScrollAnimatorMac::startScrollbarPaintTimer[1] because new PostTask interface
didn't support micro sec delay (type of |delay| was changed from "double" to
"long long"). This seems to give tasks more chances to run before task
cancellation and probably contention happens.

This CL re-adds 1 ms delay (not 0.1 ms because the current PostTask doesn't
support micro sec delay as mentioned above) and confirmed it improved the scroll
animation in the demo page (see the issue).

[1] https://codereview.chromium.org/2514733002/

BUG=713669
==========

[nhiroki, 2017-05-11 04:51:41]

Thank you.

On 2017/05/10 13:26:11, bokan wrote:
> Your commit self-references this CL in your [2] link.

Done (I copied-and-pasted the description from the issue and forgot to remove
the cyclic link :p)

[nhiroki, 2017-05-11 04:52:13]

nhiroki@chromium.org changed reviewers:
+ haraken@chromium.org

[nhiroki, 2017-05-11 04:52:13]

+haraken@, can you review this? Thanks.

[nhiroki, 2017-05-11 04:55:38]

FYI: tzik@'s CL[2] will enable to post a task with a delay under 1 ms, but this
CL uses 1 ms delay in the case we want to merge this into previous milestones.

[2] https://codereview.chromium.org/2876513002/

[haraken, 2017-05-11 05:25:33]

LGTM

[nhiroki, 2017-05-11 05:27:44]

The CQ bit was checked by nhiroki@chromium.org

[nhiroki, 2017-05-11 05:27:44]

The patchset sent to the CQ was uploaded after l-g-t-m from tzik@chromium.org
Link to the patchset: https://codereview.chromium.org/2868783006/#ps60001
(title: "add comments")

[commit-bot: I haz the power, 2017-05-11 05:28:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 05:36:17]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494480464300150,
"parent_rev": "8549ed4eaf9d95db494bd7028bf17110b26b6918", "commit_rev":
"570b67158dabf2d9f10bb12ac68762e973ed63ad"}

[commit-bot: I haz the power, 2017-05-11 05:36:35]

Description was changed from

==========
Re-add delay to PostTask in StartScrollbarPaintTimer()

My previous CL removed 0.1 ms delay from PostTask in
ScrollAnimatorMac::startScrollbarPaintTimer[1] because new PostTask interface
didn't support micro sec delay (type of |delay| was changed from "double" to
"long long"). This seems to give tasks more chances to run before task
cancellation and probably contention happens.

This CL re-adds 1 ms delay (not 0.1 ms because the current PostTask doesn't
support micro sec delay as mentioned above) and confirmed it improved the scroll
animation in the demo page (see the issue).

[1] https://codereview.chromium.org/2514733002/

BUG=713669
==========

to

==========
Re-add delay to PostTask in StartScrollbarPaintTimer()

My previous CL removed 0.1 ms delay from PostTask in
ScrollAnimatorMac::startScrollbarPaintTimer[1] because new PostTask interface
didn't support micro sec delay (type of |delay| was changed from "double" to
"long long"). This seems to give tasks more chances to run before task
cancellation and probably contention happens.

This CL re-adds 1 ms delay (not 0.1 ms because the current PostTask doesn't
support micro sec delay as mentioned above) and confirmed it improved the scroll
animation in the demo page (see the issue).

[1] https://codereview.chromium.org/2514733002/

BUG=713669

Review-Url: https://codereview.chromium.org/2868783006
Cr-Commit-Position: refs/heads/master@{#470823}
Committed:
https://chromium.googlesource.com/chromium/src/+/570b67158dabf2d9f10bb12ac687...
==========

[commit-bot: I haz the power, 2017-05-11 05:36:36]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/570b67158dabf2d9f10bb12ac687...