Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2868783003:
Add command_line to SystemInfo data structure. (Closed)
|
Created:
3 years, 7 months ago by Ken Russell (switch to Gerrit) Modified:
3 years, 7 months ago CC:
chromium-reviews, caseq+blink_chromium.org, jam, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, darin-cc_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org, nednguyen, perezju Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd command_line to SystemInfo data structure.
The real browser command line is often needed for debugging purposes.
Expose it in DevTools' experimental SystemInfo data structure.
BUG=718635
Review-Url: https://codereview.chromium.org/2868783003
Cr-Commit-Position: refs/heads/master@{#472415}
Committed: https://chromium.googlesource.com/chromium/src/+/ebbd3a5c5eee3ec38736e60c53f2ea1bc3faed6c
Patch Set 1 #Patch Set 2 : Preemptive rebase. #Patch Set 3 : Fixed compile on Windows. #
Messages
Total messages: 25 (13 generated)
kbr@chromium.org changed reviewers: + dgozman@chromium.org
Dmitry: please review. Ned, Juan: FYI. If this CL is approved, the information will be exposed to Telemetry in https://codereview.chromium.org/2871803002 .
caseq@chromium.org changed reviewers: + caseq@chromium.org
Is the goal here just making command line available to telemetry? I though we already report it as part of trace metadata: https://cs.chromium.org/chromium/src/content/browser/tracing/tracing_controll...
On 2017/05/08 22:46:49, caseq wrote: > Is the goal here just making command line available to telemetry? I though we > already report it as part of trace metadata: > https://cs.chromium.org/chromium/src/content/browser/tracing/tracing_controll... Understood that it is exposed there, but there are tests which don't use tracing (like the GPU tests) and I'd like the information to be easily exposed there. Also, this information is dumped upon browser startup, which is especially convenient for debugging.
lgtm
The CQ bit was checked by kbr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org Link to the patchset: https://codereview.chromium.org/2868783003/#ps20001 (title: "Preemptive rebase.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
The CQ bit was checked by kbr@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org Link to the patchset: https://codereview.chromium.org/2868783003/#ps40001 (title: "Fixed compile on Windows.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495004817549980,
"parent_rev": "75f368543f24bc196d03e8c657d78f59d4589d42", "commit_rev":
"ebbd3a5c5eee3ec38736e60c53f2ea1bc3faed6c"}
Message was sent while issue was closed.
Description was changed from ========== Add command_line to SystemInfo data structure. The real browser command line is often needed for debugging purposes. Expose it in DevTools' experimental SystemInfo data structure. BUG=718635 ========== to ========== Add command_line to SystemInfo data structure. The real browser command line is often needed for debugging purposes. Expose it in DevTools' experimental SystemInfo data structure. BUG=718635 Review-Url: https://codereview.chromium.org/2868783003 Cr-Commit-Position: refs/heads/master@{#472415} Committed: https://chromium.googlesource.com/chromium/src/+/ebbd3a5c5eee3ec38736e60c53f2... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/ebbd3a5c5eee3ec38736e60c53f2... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
