Expose browser command line via SystemInfo.

Expose browser command line via SystemInfo.

This CL requires changes to the DevTools implementation in order to
start reporting the browser's command line.

BUG=chromium:718635
Review-Url: https://codereview.chromium.org/2871803002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/7787540cb51333f7362d0d595d8b6ed8e754b0c1

[nednguyen, 2017-05-08 22:44:28]

nednguyen@google.com changed reviewers:
+ nednguyen@google.com

[nednguyen, 2017-05-08 22:44:28]

lgtm

https://codereview.chromium.org/2871803002/diff/1/telemetry/telemetry/interna...
File telemetry/telemetry/internal/browser/browser.py (right):

https://codereview.chromium.org/2871803002/diff/1/telemetry/telemetry/interna...
telemetry/telemetry/internal/browser/browser.py:125: logging.info('Browser
command line: %s', system_info.command_line)
One the other patch landed, I hope we can assert this equals to the command we
set in
https://github.com/catapult-project/catapult/blob/master/telemetry/telemetry/...

[Ken Russell (switch to Gerrit), 2017-05-08 22:47:09]

https://codereview.chromium.org/2871803002/diff/1/telemetry/telemetry/interna...
File telemetry/telemetry/internal/browser/browser.py (right):

https://codereview.chromium.org/2871803002/diff/1/telemetry/telemetry/interna...
telemetry/telemetry/internal/browser/browser.py:125: logging.info('Browser
command line: %s', system_info.command_line)
On 2017/05/08 22:44:28, nednguyen wrote:
> One the other patch landed, I hope we can assert this equals to the command we
> set in
>
https://github.com/catapult-project/catapult/blob/master/telemetry/telemetry/...

Yes, it would be good to make assertions like that. For the record, here's the
output from my first run of both combined CLs:

(INFO) 2017-05-08 15:20:18,198 browser._LogBrowserInfo:125  Browser command
line: /Users/kbr/src/chrome/src/out/Release/Chromium.app/Contents/MacOS/Chromium
--ignore-autoplay-restrictions --disable-domain-blocking-for-3d-apis
--disable-gpu-process-crash-limit --test-type=gpu
--enable-experimental-canvas-features --js-flags=--expose-gc
--disable-gpu-watchdog --enable-net-benchmarking --metrics-recording-only
--no-default-browser-check --no-first-run --enable-gpu-benchmarking
--disable-background-networking --proxy-server=socks://localhost:59999
--ignore-certificate-errors --disable-component-extensions-with-background-pages
--disable-default-apps --disable-search-geolocation-disclosure
--remote-debugging-port=0 --enable-crash-reporter-for-testing
--disable-component-update --window-size=1280,1024
--ppapi-flash-path=/Users/kbr/src/chrome/src/third_party/adobe/flash/binaries/ppapi/mac_64/PepperFlashPlayer.plugin
--ppapi-flash-version=99.9.999.999
--user-data-dir=/var/folders/pk/pkx9qlgj4z52ftmp_s0hng14002z4b/T/tmpGMcons
--flag-switches-begin --flag-switches-end about:blank

[Ken Russell (switch to Gerrit), 2017-05-08 22:48:12]

Actually, Ned, I realized you picked up this review even before I sent it out :)

This requires https://codereview.chromium.org/2868783003/ to be approved before
this is landed, because if changes are made in the other CL they'll have to be
mirrored here.

[Ken Russell (switch to Gerrit), 2017-05-16 22:04:53]

Found that fakes/__init__.py needed an update. We should really run at least the
telemetry_gpu_unittests on the Catapult tryservers because otherwise CLs that
land via Catapult's CQ will break rolls...

[nednguyen, 2017-05-16 22:16:02]

On 2017/05/16 22:04:53, Ken Russell wrote:
> Found that fakes/__init__.py needed an update. We should really run at least
the
> telemetry_gpu_unittests on the Catapult tryservers because otherwise CLs that
> land via Catapult's CQ will break rolls...

Lgtm

[Ken Russell (switch to Gerrit), 2017-05-17 17:37:53]

The Chrome-side CL landed; CQ'ing.

[Ken Russell (switch to Gerrit), 2017-05-17 17:37:56]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2017-05-17 17:38:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 18:01:58]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495042676790110,
"parent_rev": "12b7dd9e6af469624308f0ed916fc780a501b7dd", "commit_rev":
"7787540cb51333f7362d0d595d8b6ed8e754b0c1"}

[commit-bot: I haz the power, 2017-05-17 18:02:01]

Description was changed from

==========
Expose browser command line via SystemInfo.

This CL requires changes to the DevTools implementation in order to
start reporting the browser's command line.

BUG=chromium:718635
==========

to

==========
Expose browser command line via SystemInfo.

This CL requires changes to the DevTools implementation in order to
start reporting the browser's command line.

BUG=chromium:718635

Review-Url: https://codereview.chromium.org/2871803002
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-05-17 18:02:02]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...