Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 2868733003: Improve HTTPS error page text when SubjectAltName missing (Closed)

Created:
3 years, 7 months ago by elawrence
Modified:
3 years, 7 months ago
Reviewers:
felt
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve HTTPS error page text when SubjectAltName missing In M58, Chrome deprecated fallback to SubjectCN when determining certificate validity. This changelist improves the error string shown when a Certificate Name Mismatch error occurs and the certificate does not specify any DNS names in the X.509 SubjectAltNames extension. BUG=708268 Review-Url: https://codereview.chromium.org/2868733003 Cr-Commit-Position: refs/heads/master@{#472468} Committed: https://chromium.googlesource.com/chromium/src/+/71bba34b40a119f47747cd29048de739539bf0e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M components/ssl_errors/error_info.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M components/ssl_errors_strings.grdp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
elawrence
PTAL?
3 years, 7 months ago (2017-05-11 15:39:03 UTC) #6
felt
lgtm
3 years, 7 months ago (2017-05-15 19:33:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2868733003/1
3 years, 7 months ago (2017-05-15 20:31:14 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/228863)
3 years, 7 months ago (2017-05-15 21:27:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2868733003/1
3 years, 7 months ago (2017-05-16 19:39:44 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/179716)
3 years, 7 months ago (2017-05-16 20:45:36 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2868733003/1
3 years, 7 months ago (2017-05-17 15:35:42 UTC) #17
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 16:20:03 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/71bba34b40a119f47747cd29048d...

Powered by Google App Engine
This is Rietveld 408576698