Linux native notifications: Escape body text if body-markup is supported

Linux native notifications: Escape body text if body-markup is supported

This CL makes NotificationPlatformBridgeLinux follow Ubuntu's Notification
Development Guidelines:
https://wiki.ubuntu.com/NotificationDevelopmentGuidelines

BUG=676220
R=thestig@chromium.org

Review-Url: https://codereview.chromium.org/2868613002
Cr-Commit-Position: refs/heads/master@{#470185}
Committed: https://chromium.googlesource.com/chromium/src/+/75583a655243a5dc047509e3524822ab8ae06706

[Tom (Use chromium acct), 2017-05-06 00:21:03]

Description was changed from

==========
Linux native notifications: Escape body text if body-markup is supported

BUG=676220
R=thestig@chromium.org
==========

to

==========
Linux native notifications: Escape body text if body-markup is supported

This CL makes NotificationPlatformBridgeLinux follow Ubuntu's Notification
Development Guidelines:
https://wiki.ubuntu.com/NotificationDevelopmentGuidelines

BUG=676220
R=thestig@chromium.org
==========

[Lei Zhang, 2017-05-06 00:29:34]

lgtm

https://codereview.chromium.org/2868613002/diff/1/chrome/browser/notification...
File chrome/browser/notifications/notification_platform_bridge_linux.cc (right):

https://codereview.chromium.org/2868613002/diff/1/chrome/browser/notification...
chrome/browser/notifications/notification_platform_bridge_linux.cc:411: if
(capabilities_.count("body")) {
base::ContainsKey(capabilities_, key) here and below?

https://codereview.chromium.org/2868613002/diff/1/chrome/browser/notification...
chrome/browser/notifications/notification_platform_bridge_linux.cc:443:
actions.push_back("Settings");
Was this the one where I was asking about localization? Add a TODO so you don't
forget?

[Tom (Use chromium acct), 2017-05-08 21:12:39]

https://codereview.chromium.org/2868613002/diff/1/chrome/browser/notification...
File chrome/browser/notifications/notification_platform_bridge_linux.cc (right):

https://codereview.chromium.org/2868613002/diff/1/chrome/browser/notification...
chrome/browser/notifications/notification_platform_bridge_linux.cc:411: if
(capabilities_.count("body")) {
On 2017/05/06 00:29:34, Lei Zhang wrote:
> base::ContainsKey(capabilities_, key) here and below?

Done.

https://codereview.chromium.org/2868613002/diff/1/chrome/browser/notification...
chrome/browser/notifications/notification_platform_bridge_linux.cc:443:
actions.push_back("Settings");
On 2017/05/06 00:29:34, Lei Zhang wrote:
> Was this the one where I was asking about localization? Add a TODO so you
don't
> forget?

Done.

[Tom (Use chromium acct), 2017-05-08 21:12:45]

The CQ bit was checked by thomasanderson@google.com

[Tom (Use chromium acct), 2017-05-08 21:12:46]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2868613002/#ps20001
(title: "")

[commit-bot: I haz the power, 2017-05-08 21:14:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 04:10:17]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494277965694140,
"parent_rev": "cd5c0cc74fa7a0be9318a9cd69460d5fea4c66ad", "commit_rev":
"75583a655243a5dc047509e3524822ab8ae06706"}

[commit-bot: I haz the power, 2017-05-09 04:10:26]

Description was changed from

==========
Linux native notifications: Escape body text if body-markup is supported

This CL makes NotificationPlatformBridgeLinux follow Ubuntu's Notification
Development Guidelines:
https://wiki.ubuntu.com/NotificationDevelopmentGuidelines

BUG=676220
R=thestig@chromium.org
==========

to

==========
Linux native notifications: Escape body text if body-markup is supported

This CL makes NotificationPlatformBridgeLinux follow Ubuntu's Notification
Development Guidelines:
https://wiki.ubuntu.com/NotificationDevelopmentGuidelines

BUG=676220
R=thestig@chromium.org

Review-Url: https://codereview.chromium.org/2868613002
Cr-Commit-Position: refs/heads/master@{#470185}
Committed:
https://chromium.googlesource.com/chromium/src/+/75583a655243a5dc047509e35248...
==========

[commit-bot: I haz the power, 2017-05-09 04:10:26]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/75583a655243a5dc047509e35248...