Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2868433004: Linux native notifications: use image_path instead of image-path for spec 1.1 (Closed)

Created:
3 years, 7 months ago by Tom (Use chromium acct)
Modified:
3 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Linux native notifications: use image_path instead of image-path for spec 1.1 You're supposed to use 'image_path' for notification servers that only support the FDO Notification spec version 1.1, and 'image-path' for versions >= 1.2. ¯\_(ツ)_/¯ Also, ban servers that have a spec version <= 1.0 because these won't support notification icons at all. BUG=676220 R=thestig@chromium.org Review-Url: https://codereview.chromium.org/2868433004 Cr-Commit-Position: refs/heads/master@{#470237} Committed: https://chromium.googlesource.com/chromium/src/+/c3b7ae8000d7222d74e2d0942d1d8823ecc0fd52

Patch Set 1 #

Total comments: 5

Patch Set 2 : thestig@'s comments #

Patch Set 3 : use base::Version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -1 line) Patch
M chrome/browser/notifications/notification_platform_bridge_linux.cc View 1 2 5 chunks +33 lines, -1 line 0 comments Download
M chrome/browser/notifications/notification_platform_bridge_linux_unittest.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 24 (17 generated)
Tom (Use chromium acct)
thestig ptal
3 years, 7 months ago (2017-05-08 21:13:01 UTC) #4
Lei Zhang
lgtm https://codereview.chromium.org/2868433004/diff/20001/chrome/browser/notifications/notification_platform_bridge_linux.cc File chrome/browser/notifications/notification_platform_bridge_linux.cc (right): https://codereview.chromium.org/2868433004/diff/20001/chrome/browser/notifications/notification_platform_bridge_linux.cc#newcode507 chrome/browser/notifications/notification_platform_bridge_linux.cc:507: image_path_writer.AppendString("image_path"); image_path_writer.AppendString(some_eval ? "image_path" : "image-path"); ? https://codereview.chromium.org/2868433004/diff/20001/chrome/browser/notifications/notification_platform_bridge_linux.cc#newcode738 ...
3 years, 7 months ago (2017-05-08 21:51:19 UTC) #5
Tom (Use chromium acct)
https://codereview.chromium.org/2868433004/diff/20001/chrome/browser/notifications/notification_platform_bridge_linux.cc File chrome/browser/notifications/notification_platform_bridge_linux.cc (right): https://codereview.chromium.org/2868433004/diff/20001/chrome/browser/notifications/notification_platform_bridge_linux.cc#newcode507 chrome/browser/notifications/notification_platform_bridge_linux.cc:507: image_path_writer.AppendString("image_path"); On 2017/05/08 21:51:19, Lei Zhang wrote: > image_path_writer.AppendString(some_eval ...
3 years, 7 months ago (2017-05-08 22:46:07 UTC) #6
Lei Zhang
https://codereview.chromium.org/2868433004/diff/20001/chrome/browser/notifications/notification_platform_bridge_linux.cc File chrome/browser/notifications/notification_platform_bridge_linux.cc (right): https://codereview.chromium.org/2868433004/diff/20001/chrome/browser/notifications/notification_platform_bridge_linux.cc#newcode738 chrome/browser/notifications/notification_platform_bridge_linux.cc:738: int spec_version_major_ = -1; On 2017/05/08 22:46:07, Tom Anderson ...
3 years, 7 months ago (2017-05-08 22:54:26 UTC) #8
Tom (Use chromium acct)
On 2017/05/08 22:54:26, Lei Zhang wrote: > https://codereview.chromium.org/2868433004/diff/20001/chrome/browser/notifications/notification_platform_bridge_linux.cc > File chrome/browser/notifications/notification_platform_bridge_linux.cc (right): > > https://codereview.chromium.org/2868433004/diff/20001/chrome/browser/notifications/notification_platform_bridge_linux.cc#newcode738 ...
3 years, 7 months ago (2017-05-08 22:59:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2868433004/60001
3 years, 7 months ago (2017-05-09 05:25:23 UTC) #21
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 05:33:27 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c3b7ae8000d7222d74e2d0942d1d...

Powered by Google App Engine
This is Rietveld 408576698