Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2868523002: [LayoutNG] Don't use the margin-strut in the OOF static-position if zero-height. (Closed)

Created:
3 years, 7 months ago by ikilpatrick
Modified:
3 years, 7 months ago
Reviewers:
Gleb Lanbin
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Don't use the margin-strut in the OOF static-position if zero-height. This patch does two things: - Doesn't include the margin strut in the OOF static-position if we are currently going to be a zero-height-div. This gives a static block offset of 0 relative to its immediate parent, which is correct. - Positions zero-height fragments using *their* end margin strut. Not the previous margin strut. BUG=635619 Review-Url: https://codereview.chromium.org/2868523002 Cr-Commit-Position: refs/heads/master@{#469882} Committed: https://chromium.googlesource.com/chromium/src/+/32b0510d7d81ee6bb988d9283336320306debbdf

Patch Set 1 #

Patch Set 2 : spelling. #

Patch Set 3 : update testexpections for linux failures. #

Patch Set 4 : rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -27 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 10 chunks +0 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 1 3 chunks +19 lines, -6 lines 0 comments Download

Messages

Total messages: 20 (15 generated)
ikilpatrick
3 years, 7 months ago (2017-05-05 20:06:40 UTC) #3
Gleb Lanbin
lgtm
3 years, 7 months ago (2017-05-05 20:26:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2868523002/20001
3 years, 7 months ago (2017-05-05 21:35:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2868523002/60001
3 years, 7 months ago (2017-05-06 05:12:23 UTC) #17
commit-bot: I haz the power
3 years, 7 months ago (2017-05-06 19:21:18 UTC) #20
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/32b0510d7d81ee6bb988d9283336...

Powered by Google App Engine
This is Rietveld 408576698