third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h - Issue 2868523002: [LayoutNG] Don't use the margin-strut in the OOF static-position if zero-height.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h

Issue 2868523002: [LayoutNG] Don't use the margin-strut in the OOF static-position if zero-height. (Closed)

Patch Set: rebase. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h

index 870d2bc347ff3ca0f96bf00958a22903f8d68f66..d1bf12a165ecd2d9f6d1eba3205aed692c3e1fcd 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h

+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h

@@ -95,7 +95,7 @@ class CORE_EXPORT NGBlockLayoutAlgorithm

// BFC Offset is known here because of the padding.

// <div style="padding: 1px">

// <div id="empty-div" style="margins: 1px"></div>

- NGLogicalOffset PositionWithParentBfc();

+ NGLogicalOffset PositionWithParentBfc(const NGBoxFragment&);

NGLogicalOffset PositionLegacy(const NGConstraintSpace& child_space);