Ensure InfoBarManager is moved when preload tab is set as current tab.

Ensure InfoBarManager is moved when preload tab is set as current tab.

BUG=717609
Review-Url: https://codereview.chromium.org/2868433003
Cr-Commit-Position: refs/heads/master@{#470436}
Committed: https://chromium.googlesource.com/chromium/src/+/79909fbb894fa48c8a45a4de6079812668ee2da1

[michaeldo, 2017-05-05 17:54:12]

michaeldo@chromium.org changed reviewers:
+ rohitrao@chromium.org

[rohitrao (ping after 24h), 2017-05-09 14:40:17]

lgtm

https://codereview.chromium.org/2868433003/diff/1/ios/chrome/browser/ui/brows...
File ios/chrome/browser/ui/browser_view_controller.mm (right):

https://codereview.chromium.org/2868433003/diff/1/ios/chrome/browser/ui/brows...
ios/chrome/browser/ui/browser_view_controller.mm:4632: [self
installDelegatesForTab:newTab];
Does the new block of code need to come before |installDelegatesForTab|?  If so,
please add a comment explaining why.  If not, consider moving the new code to be
after this call, rather than in the middle of the uninstall/install dance.

[michaeldo, 2017-05-09 21:12:47]

https://codereview.chromium.org/2868433003/diff/1/ios/chrome/browser/ui/brows...
File ios/chrome/browser/ui/browser_view_controller.mm (right):

https://codereview.chromium.org/2868433003/diff/1/ios/chrome/browser/ui/brows...
ios/chrome/browser/ui/browser_view_controller.mm:4632: [self
installDelegatesForTab:newTab];
On 2017/05/09 14:40:17, rohitrao (ping after 24h) wrote:
> Does the new block of code need to come before |installDelegatesForTab|?  If
so,
> please add a comment explaining why.  If not, consider moving the new code to
be
> after this call, rather than in the middle of the uninstall/install dance.

I thought it did based on the other methods here, but no. There is not a
dependency, so I moved this new block to after the install call.

[michaeldo, 2017-05-09 21:12:53]

The CQ bit was checked by michaeldo@chromium.org

[michaeldo, 2017-05-09 21:12:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
rohitrao@chromium.org
Link to the patchset: https://codereview.chromium.org/2868433003/#ps20001
(title: "Move installDelegatesCall.")

[commit-bot: I haz the power, 2017-05-09 21:13:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 23:42:53]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494364373429080,
"parent_rev": "775d86740a5466ab0932d7d24cb7a39ba852371b", "commit_rev":
"79909fbb894fa48c8a45a4de6079812668ee2da1"}

[commit-bot: I haz the power, 2017-05-09 23:43:07]

Description was changed from

==========
Ensure InfoBarManager is moved when preload tab is set as current tab.

BUG=717609
==========

to

==========
Ensure InfoBarManager is moved when preload tab is set as current tab.

BUG=717609

Review-Url: https://codereview.chromium.org/2868433003
Cr-Commit-Position: refs/heads/master@{#470436}
Committed:
https://chromium.googlesource.com/chromium/src/+/79909fbb894fa48c8a45a4de6079...
==========

[commit-bot: I haz the power, 2017-05-09 23:43:08]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/79909fbb894fa48c8a45a4de6079...