Ensure InfoBarManager is moved when preload tab is set as current tab.

ios/chrome/browser/ui/browser_view_controller.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/browser_view_controller.h"
 
 #import <AssetsLibrary/AssetsLibrary.h>
 #import <MobileCoreServices/MobileCoreServices.h>
 #import <PassKit/PassKit.h>
 #import <Photos/Photos.h>
@@ skipping 4605 matching lines @@
     [_contextualSearchController enableContextualSearch:enableContextualSearch];
   }
 }
 
 // Observer method, tab replaced.
 - (void)tabModel:(TabModel*)model
     didReplaceTab:(Tab*)oldTab
           withTab:(Tab*)newTab
           atIndex:(NSUInteger)index {
   [self uninstallDelegatesForTab:oldTab];
+
+  if (_infoBarContainer) {
+    infobars::InfoBarManager* infoBarManager = [newTab infoBarManager];
+    _infoBarContainer->ChangeInfoBarManager(infoBarManager);
+  }
+
   [self installDelegatesForTab:newTab];

[rohitrao (ping after 24h), 2017/05/09 14:40:17]

Does the new block of code need to come before |installDelegatesForTab|?  If so,
please add a comment explaining why.  If not, consider moving the new code to be
after this call, rather than in the middle of the uninstall/install dance.

[michaeldo, 2017/05/09 21:12:46]

I thought it did based on the other methods here, but no. There is not a
dependency, so I moved this new block to after the install call.

 
   // Add |newTab|'s view to the hierarchy if it's the current Tab.
   if (self.active && model.currentTab == newTab)
     [self displayTab:newTab isNewSelection:NO];
 }
 
 // A tab has been removed, remove its views from display if necessary.
 - (void)tabModel:(TabModel*)model
     didRemoveTab:(Tab*)tab
          atIndex:(NSUInteger)index {
@@ skipping 547 matching lines @@
 
 - (UIView*)voiceSearchButton {
   return _voiceSearchButton;
 }
 
 - (id<LogoAnimationControllerOwner>)logoAnimationControllerOwner {
   return [self currentLogoAnimationControllerOwner];
 }
 
 @end