Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2868413003: Fix textPath textLength position adjustment for the spacing case (Closed)

Created:
3 years, 7 months ago by fs
Modified:
3 years, 7 months ago
Reviewers:
Stephen Chennney, pdr.
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, fmalita+watch_chromium.org, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix textPath textLength position adjustment for the spacing case Follow-up to https://codereview.chromium.org/2870393002, adjusting the <textPath> 'textLength' computation in the same way. BUG=719522 Review-Url: https://codereview.chromium.org/2868413003 Cr-Commit-Position: refs/heads/master@{#471248} Committed: https://chromium.googlesource.com/chromium/src/+/1cc74004b24c8a79dcee523e913c1d929c1167da

Patch Set 1 #

Patch Set 2 : Updated baselines #

Messages

Total messages: 17 (12 generated)
fs
Part Deux
3 years, 7 months ago (2017-05-11 21:45:08 UTC) #8
pdr.
On 2017/05/11 at 21:45:08, fs wrote: > Part Deux LGTM! Off-by-one, the 2nd hardest computer ...
3 years, 7 months ago (2017-05-11 22:46:23 UTC) #9
fs
On 2017/05/11 at 22:46:23, pdr wrote: > On 2017/05/11 at 21:45:08, fs wrote: > > ...
3 years, 7 months ago (2017-05-12 08:08:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2868413003/20001
3 years, 7 months ago (2017-05-12 08:08:32 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 08:16:25 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1cc74004b24c8a79dcee523e913c...

Powered by Google App Engine
This is Rietveld 408576698