Fix textLength position adjustment for the "adjust spacing" case

Fix textLength position adjustment for the "adjust spacing" case

There should be no advance adjustment after the last character (really,
"typographic unit"), so divide the excess space by the character count
minus one - i.e the number of gaps - rather than the character count.

BUG=719522
Review-Url: https://codereview.chromium.org/2870393002
Cr-Commit-Position: refs/heads/master@{#470928}
Committed: https://chromium.googlesource.com/chromium/src/+/308e792b8d4648ba4e298c80faca80bc780b5735

[fs, 2017-05-10 09:25:34]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 09:26:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 11:29:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 11:29:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fs, 2017-05-10 14:42:08]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 14:43:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2017-05-10 16:06:09]

fs@opera.com changed reviewers:
+ pdr@chromium.org, schenney@chromium.org

[fs, 2017-05-10 16:06:10]

https://codereview.chromium.org/2870393002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/svg/SVGTextChunkBuilder.cpp (left):

https://codereview.chromium.org/2870393002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/svg/SVGTextChunkBuilder.cpp:212:
length_accumulator.NumCharacters();
When I had finished this I remembered/noticed that we have this calculation in
one more place =/ ('textLength' for <textPath>). Will fix that in a follow-up
CL.

[commit-bot: I haz the power, 2017-05-10 16:36:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 16:36:44]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Stephen Chennney, 2017-05-10 17:08:00]

lgtm

lgtm

Great to see quick turnaround on these simple issues.

[fs, 2017-05-10 17:24:06]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2017-05-10 17:25:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 19:46:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 19:46:28]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fs, 2017-05-10 21:48:56]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2017-05-10 21:50:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 23:24:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 23:24:27]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pdr., 2017-05-10 23:27:48]

On 2017/05/10 at 23:24:27, commit-bot wrote:
> Try jobs failed on following builders:
>   linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

This bot finally cleared up. Marking for CQ again.

[pdr., 2017-05-10 23:27:50]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2017-05-10 23:29:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 00:54:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 00:54:53]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fs, 2017-05-11 10:12:13]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2017-05-11 10:13:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 12:13:05]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494497533724930,
"parent_rev": "adbcf1feb08731127872db3b215e9c7742335647", "commit_rev":
"308e792b8d4648ba4e298c80faca80bc780b5735"}

[commit-bot: I haz the power, 2017-05-11 12:13:19]

Description was changed from

==========
Fix textLength position adjustment for the "adjust spacing" case

There should be no advance adjustment after the last character (really,
"typographic unit"), so divide the excess space by the character count
minus one - i.e the number of gaps - rather than the character count.

BUG=719522
==========

to

==========
Fix textLength position adjustment for the "adjust spacing" case

There should be no advance adjustment after the last character (really,
"typographic unit"), so divide the excess space by the character count
minus one - i.e the number of gaps - rather than the character count.

BUG=719522

Review-Url: https://codereview.chromium.org/2870393002
Cr-Commit-Position: refs/heads/master@{#470928}
Committed:
https://chromium.googlesource.com/chromium/src/+/308e792b8d4648ba4e298c80faca...
==========

[commit-bot: I haz the power, 2017-05-11 12:13:21]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/308e792b8d4648ba4e298c80faca...