Improvements to the Payment Address Form UI

Improvements to the Payment Address Form UI

Vertically align a text field and a dropdown field on a single line,
in the payment request form.

Also, according to the UX designer, locality and dependent-locality
fields (city, .. ) need a full line, on the payment address form.

BUG=707860
Review-Url: https://codereview.chromium.org/2868313002
Cr-Commit-Position: refs/heads/master@{#472573}
Committed: https://chromium.googlesource.com/chromium/src/+/721a3c1132e02f2f45c4eab292ef4418ff384bf3

[Parastoo, 2017-05-12 16:17:12]

Description was changed from

==========
Payment Address Form UI

BUG=
==========

to

==========
Improvements to the Payment Address Form UI

Vertically align a text field and a dropdown field on a single line,
in the payment request form.

Also, according to the UX designer, locality and dependent-locality
fields (city, .. ) need a full line.

BUG=707860
==========

[Parastoo, 2017-05-12 16:18:22]

Description was changed from

==========
Improvements to the Payment Address Form UI

Vertically align a text field and a dropdown field on a single line,
in the payment request form.

Also, according to the UX designer, locality and dependent-locality
fields (city, .. ) need a full line.

BUG=707860
==========

to

==========
Improvements to the Payment Address Form UI

Vertically align a text field and a dropdown field on a single line,
in the payment request form.

Also, according to the UX designer, locality and dependent-locality
fields (city, .. ) need a full line, on the payment address form.

BUG=707860
==========

[Parastoo, 2017-05-12 16:53:01]

The CQ bit was checked by parastoog@google.com

[commit-bot: I haz the power, 2017-05-12 16:53:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 16:53:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 16:53:33]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[Parastoo, 2017-05-12 16:57:07]

Patchset #2 (id:20001) has been deleted

[Parastoo, 2017-05-12 16:57:22]

The CQ bit was checked by parastoog@google.com

[commit-bot: I haz the power, 2017-05-12 16:58:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 16:58:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 16:58:05]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[Parastoo, 2017-05-12 16:59:07]

parastoog@google.com changed reviewers:
+ dfalcantara@chromium.org, mathp@chromium.org

[Parastoo, 2017-05-12 16:59:08]

mathp@chromium.org: Please review changes in 

dfalcantara@chromium.org: Please review changes in

[Parastoo, 2017-05-12 16:59:19]

The CQ bit was checked by parastoog@google.com

[Parastoo, 2017-05-12 16:59:40]

The CQ bit was checked by parastoog@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 16:59:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 16:59:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 16:59:59]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[Parastoo, 2017-05-12 17:27:59]

The CQ bit was checked by parastoog@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 17:29:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Parastoo, 2017-05-12 17:29:51]

The CQ bit was unchecked by parastoog@google.com

[Parastoo, 2017-05-12 17:30:13]

The CQ bit was checked by parastoog@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 17:31:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 18:38:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 18:38:07]

Dry run: This issue passed the CQ dry run.

[Mathieu, 2017-05-12 20:14:55]

lgtm thanks

[Parastoo, 2017-05-17 17:35:10]

parastoog@google.com changed reviewers:
- dfalcantara@chromium.org

[Parastoo, 2017-05-17 17:36:13]

parastoog@google.com changed reviewers:
+ dtrainor@chromium.org

[Parastoo, 2017-05-17 17:36:13]

dtrainor@chromium.org: Please review changes in

[Parastoo, 2017-05-17 17:36:16]

dtrainor@chromium.org: Please review changes in

[David Trainor- moved to gerrit, 2017-05-17 19:14:19]

lgtm % nit

https://codereview.chromium.org/2868313002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java
(right):

https://codereview.chromium.org/2868313002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java:356:
if (fieldModel.isTextField() && nextFieldModel.isDropdownField()
Can we group these with () just to make it more clear?  Thanks!

[Parastoo, 2017-05-17 19:48:41]

The CQ bit was checked by parastoog@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 19:49:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Parastoo, 2017-05-17 19:50:10]

https://codereview.chromium.org/2868313002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java
(right):

https://codereview.chromium.org/2868313002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java:356:
if (fieldModel.isTextField() && nextFieldModel.isDropdownField()
On 2017/05/17 19:14:18, David Trainor-ping if over 24h wrote:
> Can we group these with () just to make it more clear?  Thanks!

Done.

[commit-bot: I haz the power, 2017-05-17 20:48:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 20:48:48]

Dry run: This issue passed the CQ dry run.

[Parastoo, 2017-05-17 20:55:02]

The CQ bit was checked by parastoog@google.com

[Parastoo, 2017-05-17 20:55:03]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org,
dtrainor@chromium.org
Link to the patchset: https://codereview.chromium.org/2868313002/#ps60001
(title: "Nit")

[commit-bot: I haz the power, 2017-05-17 20:56:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 21:18:43]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495054502602730,
"parent_rev": "fe689d0fc9750a2e953422336a6fbbb55ab9c20c", "commit_rev":
"721a3c1132e02f2f45c4eab292ef4418ff384bf3"}

[commit-bot: I haz the power, 2017-05-17 21:18:56]

Description was changed from

==========
Improvements to the Payment Address Form UI

Vertically align a text field and a dropdown field on a single line,
in the payment request form.

Also, according to the UX designer, locality and dependent-locality
fields (city, .. ) need a full line, on the payment address form.

BUG=707860
==========

to

==========
Improvements to the Payment Address Form UI

Vertically align a text field and a dropdown field on a single line,
in the payment request form.

Also, according to the UX designer, locality and dependent-locality
fields (city, .. ) need a full line, on the payment address form.

BUG=707860

Review-Url: https://codereview.chromium.org/2868313002
Cr-Commit-Position: refs/heads/master@{#472573}
Committed:
https://chromium.googlesource.com/chromium/src/+/721a3c1132e02f2f45c4eab292ef...
==========

[commit-bot: I haz the power, 2017-05-17 21:19:01]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/721a3c1132e02f2f45c4eab292ef...