chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java - Issue 2868313002: Improvements to the Payment Address Form UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java

Issue 2868313002: Improvements to the Payment Address Form UI (Closed)

Patch Set: Nit Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/values/dimens.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDialog.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java

index aaaad4a92e795c7d4069721fd0797b81ba760cac..64dc015d5bec1e1a7af6a1a7d8a26d0719c42a35 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java

@@ -388,7 +388,8 @@ public class AddressEditor

// Labels depend on country, e.g., state is called province in some countries. These are

// already localized.

field.setLabel(component.label);

- field.setIsFullLine(component.isFullLine);

+ field.setIsFullLine(component.isFullLine || component.id == AddressField.LOCALITY

+ || component.id == AddressField.DEPENDENT_LOCALITY);

if (component.id == AddressField.ADMIN_AREA && field.isDropdownField()) {

field.setDropdownKeyValues(