DescriptionReland of Remove dangling PlayingState pointers in WebRtcAudioRenderer. (patchset #1 id:1 of https://codereview.chromium.org/2856943003/ )
Reason for revert:
Relanding this as reverting didn't improve the metrics.
Original issue's description:
> Revert of Remove dangling PlayingState pointers in WebRtcAudioRenderer. (patchset #4 id:60001 of https://codereview.chromium.org/2758453004/ )
>
> Reason for revert:
> This causes a memory use increase across the board on Android, even when WebRTC isn't used.
>
> Original issue's description:
> > Remove dangling PlayingState pointers in WebRtcAudioRenderer.
> >
> > This solution is a bit of a hack, but it works. Did manual testing and ran
> > unit tests. Bug 697256 does not reproduce with this patch.
> >
> > R=tommi@chromium.org
> >
> > BUG=697256
> >
> > Review-Url: https://codereview.chromium.org/2758453004
> > Cr-Commit-Position: refs/heads/master@{#458025}
> > Committed: https://chromium.googlesource.com/chromium/src/+/ba21ffd704aebcc8a5e5e1ab1f072e9b79b51fcb
>
> TBR=tommi@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=697256, 703743
>
> Review-Url: https://codereview.chromium.org/2856943003
> Cr-Commit-Position: refs/heads/master@{#468984}
> Committed: https://chromium.googlesource.com/chromium/src/+/a5f87e7a6177d32e5cf9cfdc39753fd7753814e2
TBR=tommi@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=697256, 703743
Review-Url: https://codereview.chromium.org/2868013002
Cr-Commit-Position: refs/heads/master@{#470288}
Committed: https://chromium.googlesource.com/chromium/src/+/abd2c36fd30e3b814a4f0f5ce024dd583e71af1a
Patch Set 1 #
Messages
Total messages: 7 (4 generated)
|