Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Issue 2856943003: Revert of Remove dangling PlayingState pointers in WebRtcAudioRenderer. (Closed)

Created:
3 years, 7 months ago by Max Morin
Modified:
3 years, 7 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, o1ka, Solis, mikecase (-- gone --)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove dangling PlayingState pointers in WebRtcAudioRenderer. (patchset #4 id:60001 of https://codereview.chromium.org/2758453004/ ) Reason for revert: This causes a memory use increase across the board on Android, even when WebRTC isn't used. Original issue's description: > Remove dangling PlayingState pointers in WebRtcAudioRenderer. > > This solution is a bit of a hack, but it works. Did manual testing and ran > unit tests. Bug 697256 does not reproduce with this patch. > > R=tommi@chromium.org > > BUG=697256 > > Review-Url: https://codereview.chromium.org/2758453004 > Cr-Commit-Position: refs/heads/master@{#458025} > Committed: https://chromium.googlesource.com/chromium/src/+/ba21ffd704aebcc8a5e5e1ab1f072e9b79b51fcb TBR=tommi@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=697256, 703743 Review-Url: https://codereview.chromium.org/2856943003 Cr-Commit-Position: refs/heads/master@{#468984} Committed: https://chromium.googlesource.com/chromium/src/+/a5f87e7a6177d32e5cf9cfdc39753fd7753814e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -44 lines) Patch
M content/renderer/media/webrtc_audio_renderer.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/renderer/media/webrtc_audio_renderer.cc View 5 chunks +7 lines, -40 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Max Morin
Created Revert of Remove dangling PlayingState pointers in WebRtcAudioRenderer.
3 years, 7 months ago (2017-05-03 10:45:28 UTC) #1
Max Morin
Tommi: PTAL.
3 years, 7 months ago (2017-05-03 10:47:17 UTC) #4
tommi (sloooow) - chröme
lgtm
3 years, 7 months ago (2017-05-03 11:49:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856943003/1
3 years, 7 months ago (2017-05-03 11:50:57 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/375490)
3 years, 7 months ago (2017-05-03 14:15:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856943003/1
3 years, 7 months ago (2017-05-03 15:14:32 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/a5f87e7a6177d32e5cf9cfdc39753fd7753814e2
3 years, 7 months ago (2017-05-03 15:41:46 UTC) #14
Max Morin
3 years, 7 months ago (2017-05-09 10:40:36 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2868013002/ by maxmorin@chromium.org.

The reason for reverting is: Relanding this as reverting didn't improve the
metrics..

Powered by Google App Engine
This is Rietveld 408576698