Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2458)

Unified Diff: ash/system/network/network_state_list_detailed_view.cc

Issue 2867933002: Fix activation issues with SystemTrayBubble. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/system/tray/system_tray.cc » ('j') | ash/system/tray/system_tray.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/system/network/network_state_list_detailed_view.cc
diff --git a/ash/system/network/network_state_list_detailed_view.cc b/ash/system/network/network_state_list_detailed_view.cc
index f168edd497699675f958fe189da371a1e0e76a31..df73172eec4e6f33d87ce0a8f715514a3795bff5 100644
--- a/ash/system/network/network_state_list_detailed_view.cc
+++ b/ash/system/network/network_state_list_detailed_view.cc
@@ -98,7 +98,6 @@ class NetworkStateListDetailedView::InfoBubble
set_shadow(views::BubbleBorder::NO_ASSETS);
set_anchor_view_insets(gfx::Insets(0, 0, kBubbleMargin, 0));
set_notify_enter_exit_on_child(true);
- set_close_on_deactivate(true);
SetLayoutManager(new views::FillLayout());
AddChildView(content);
}
@@ -353,13 +352,8 @@ void NetworkStateListDetailedView::ToggleInfoBubble() {
bool NetworkStateListDetailedView::ResetInfoBubble() {
if (!info_bubble_)
return false;
- // After losing activation, the InfoBubble will be closed.
- owner()
- ->system_tray()
- ->GetSystemBubble()
- ->bubble_view()
- ->GetWidget()
- ->Activate();
+
+ info_bubble_->GetWidget()->Close();
return true;
}
« no previous file with comments | « no previous file | ash/system/tray/system_tray.cc » ('j') | ash/system/tray/system_tray.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698